class A {function__construct(string$a) {}}try {$a =$serializer->deserialize('{}', A::class,'json');}catch (NotNormalizableValueException$e) {var_dump($e->getMessage());// "Failed to create object because class misses the 'a' property."var_dump($e->getPath());// "a"var_dump($e->getExpectedTypes());// ["string"]var_dump($e->getCurrentType());// "array"}

thengetCurrentType returns incorrect"array" value instead of expected"null" value.

[Serializer] Fix type for missing property

5de8771

ElisDN requested a review fromdunglas as acode owner

May 13, 2024 17:07

carsonbot added Status: Needs Review Bug Serializer labels

May 13, 2024

carsonbot added this to the5.4 milestone

May 13, 2024

Copy link

carsonbot commentedMay 13, 2024

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

xabbuh reviewed

May 15, 2024

View reviewed changes

src/Symfony/Component/Serializer/Normalizer/AbstractNormalizer.php

		$exception = NotNormalizableValueException::createForUnexpectedDataType(
		sprintf('Failed to create object because the class misses the "%s" property.',$constructorParameter->name),
		$data,
		null,

Copy link

Member

xabbuhMay 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Shouldn't this be$parameterData instead?

Copy link

ContributorAuthor

ElisDNMay 15, 2024•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

There is$parameterData = $data[$key] statement in cases above. But in this case (with missing parameter) the$data[$key] value does not exist and$parameterData will be empty too.