Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Messenger] Added the ability to forceRedisCluster#54866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
adideas wants to merge1 commit intosymfony:7.4
base:7.4
Choose a base branch
Loading
fromadideas:patch-1

Conversation

adideas
Copy link

@adideasadideas commentedMay 8, 2024
edited by OskarStark
Loading

QA
Branch?7.1
Bug fix?no
New feature?yes
Deprecations?no
IssuesFix #...
LicenseMIT

Previously, an array had to be specified to support a cluster. But the nodes can change. Instead of "redis://host-0,redis://host-1" we specify "redis://server?redis_cluster=true"

valtzu reacted with thumbs up emoji
Previously, an array had to be specified to support a cluster. But the nodes can change. Instead of "redis://host-0,redis://host-1" we specify "redis://server?redis_cluster=true"
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@valtzu
Copy link
Contributor

valtzu commentedMay 8, 2024
edited
Loading

I like it.

Any reason to call the parameterredis_cluster instead of justcluster?

EDIT: ok I guess it's kinda in line withredis_sentinel

@adideas
Copy link
Author

If you specify a cluster but do not specify it as an array, then a regular redis will start. Then the cluster reports MOVED and everything breaks down.

In the log you can see an error that is most incomprehensible "MOVED ...". You start looking in the documentation and find the redis_cluster parameter in the cache. And then you think why it’s not in "Messenger"

@OskarStarkOskarStark changed the title[Messenger] Added the ability to force use RedisCluster in Messenger[Messenger] Added the ability to forceRedisClusterMay 8, 2024
@xabbuhxabbuh modified the milestones:7.1,7.2May 15, 2024
@adideas
Copy link
Author

Tell me, did you fix the tests?

@fabpotfabpot modified the milestones:7.2,7.3Nov 20, 2024
@fabpotfabpot modified the milestones:7.3,7.4May 26, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
7.4
Development

Successfully merging this pull request may close these issues.

5 participants
@adideas@carsonbot@valtzu@fabpot@xabbuh

[8]ページ先頭

©2009-2025 Movatter.jp