Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Messenger] Added the ability to forceRedisCluster
#54866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:7.4
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Previously, an array had to be specified to support a cluster. But the nodes can change. Instead of "redis://host-0,redis://host-1" we specify "redis://server?redis_cluster=true"
carsonbot commentedMay 8, 2024
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
valtzu commentedMay 8, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I like it. Any reason to call the parameter EDIT: ok I guess it's kinda in line with |
If you specify a cluster but do not specify it as an array, then a regular redis will start. Then the cluster reports MOVED and everything breaks down. In the log you can see an error that is most incomprehensible "MOVED ...". You start looking in the documentation and find the redis_cluster parameter in the cache. And then you think why it’s not in "Messenger" |
RedisCluster
Tell me, did you fix the tests? |
Uh oh!
There was an error while loading.Please reload this page.
Previously, an array had to be specified to support a cluster. But the nodes can change. Instead of "redis://host-0,redis://host-1" we specify "redis://server?redis_cluster=true"