Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Serializer] Fixed "Warning: Attempt to read property "value" on string"#54851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[Serializer] Fixed "Warning: Attempt to read property "value" on string"#54851
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedMay 6, 2024
Hey! Thanks for your PR. You are targeting branch "7.1" but it seems your PR description refers to branch "7.1.0-BETA1". Cheers! Carsonbot |
xabbuh left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can we cover this change with a test to prevent future regressions?
michaljusiega commentedMay 6, 2024
I'll try tomorrow. |
michaljusiega commentedMay 6, 2024
This is a reproduce code at the moment: |
michaljusiega commentedMay 7, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@xabbuh I gave up. Could you help me ? |
58fccef toeda1dfcComparexabbuh commentedMay 17, 2024
thanks for the snippet, I was able to create a test based on it 👍 |
eda1dfc to975d64cCompare975d64c to90251c9Comparexabbuh commentedMay 17, 2024
Thank you@michaljusiega. |
michaljusiega commentedMay 17, 2024
Thank you too@xabbuh ! |
Uh oh!
There was an error while loading.Please reload this page.
Hi! I've updated my project to
7.1.0-BETA1and I found an error.After update I got:
Warning: Attempt to read property "value" on stringinvendor/symfony/serializer/Normalizer/AbstractObjectNormalizer.php:748because in733 linethe enum-case of valueTypeIdentifierhas been already readed.Quite not sure if tests are possible here.