Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[VarExporter] fixProxyHelper::generateLazyProxy() when a method returns null#54850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:6.4fromnikophil:fix/allow-null-return-type
May 7, 2024

Conversation

@nikophil
Copy link
Contributor

@nikophilnikophil commentedMay 6, 2024•
edited
Loading

QA
Branch?6.4
Bug fix?yes
New feature?no
Deprecations?no
LicenseMIT

When a methods has such a signature:

publicfunction foo():null

the methodProxyHelper::generateLazyProxy() produces a wrong code:

publicfunction foo(): ?null

This PR fixes this.

@carsonbotcarsonbot added this to the6.4 milestoneMay 6, 2024
@nikophilnikophilforce-pushed thefix/allow-null-return-type branch 2 times, most recently from6fd1794 to330dcc7CompareMay 6, 2024 14:51
@nikophilnikophilforce-pushed thefix/allow-null-return-type branch from330dcc7 toaeecd29CompareMay 6, 2024 15:16
@nikophilnikophilforce-pushed thefix/allow-null-return-type branch fromaeecd29 to673bb6bCompareMay 6, 2024 15:18
@nikophilnikophilforce-pushed thefix/allow-null-return-type branch from673bb6b to59b3b7aCompareMay 7, 2024 07:13
@nicolas-grekas
Copy link
Member

Can you also please update src/Symfony/Component/VarDumper/Caster/ReflectionCaster.php? It has the same issue (two times)

nikophil reacted with thumbs up emoji

@nikophilnikophilforce-pushed thefix/allow-null-return-type branch 2 times, most recently fromb3ab90f to37ba6e7CompareMay 7, 2024 07:47
@nikophilnikophilforce-pushed thefix/allow-null-return-type branch from37ba6e7 to0067eabCompareMay 7, 2024 07:51
@nikophilnikophilforce-pushed thefix/allow-null-return-type branch 2 times, most recently from0842909 to23c16c6CompareMay 7, 2024 08:05
@nikophilnikophilforce-pushed thefix/allow-null-return-type branch from23c16c6 todc083feCompareMay 7, 2024 08:56
@fabpot
Copy link
Member

Thank you@nikophil.

@fabpotfabpot merged commit0704e4e intosymfony:6.4May 7, 2024
@fabpotfabpot mentioned this pull requestMay 17, 2024
This was referencedJun 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@fabpotfabpotfabpot approved these changes

@xabbuhxabbuhxabbuh approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

5 participants

@nikophil@nicolas-grekas@fabpot@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp