Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Messenger] Don't drop stamps when message validation fails#54842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
54ad10f toeafba2eComparesrc/Symfony/Component/Messenger/Exception/EnvelopeAwareExceptionInterface.phpShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
chalasr approved these changesMay 4, 2024
fabpot approved these changesMay 7, 2024
f51aa95 tofed32dcCompareMember
fabpot commentedMay 7, 2024
Thank you@valtzu. |
Member
fabpot commentedMay 7, 2024
@valtzu I've merged this PR up to 7.1. Can you submit a PR on 7.1 to remove the |
fabpot added a commit that referenced this pull requestMay 7, 2024
…e` internal (valtzu)This PR was merged into the 7.1 branch.Discussion----------[Messenger] Don't mark `EnvelopeAwareExceptionInterface` internal| Q | A| ------------- | ---| Branch? | 7.1| Bug fix? | no| New feature? | yes| Deprecations? | no| License | MITAs discussed [here](#54842 (comment)), let's expose `EnvelopeAwareExceptionInterface` to allow custom Messenger middlewares throw a custom exception without causing stamps from previous middlewares being dropped.Commits-------7713fd1 Don't mark EnvelopeAwareExceptionInterface internal
symfony-splitter pushed a commit to symfony/messenger that referenced this pull requestMay 7, 2024
…e` internal (valtzu)This PR was merged into the 7.1 branch.Discussion----------[Messenger] Don't mark `EnvelopeAwareExceptionInterface` internal| Q | A| ------------- | ---| Branch? | 7.1| Bug fix? | no| New feature? | yes| Deprecations? | no| License | MITAs discussed [here](symfony/symfony#54842 (comment)), let's expose `EnvelopeAwareExceptionInterface` to allow custom Messenger middlewares throw a custom exception without causing stamps from previous middlewares being dropped.Commits-------7713fd17f5 Don't mark EnvelopeAwareExceptionInterface internal
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ValidationMiddlewarehas the same issue asDispatchAfterCurrentBusMiddlewaredid before thefix: if message validation fails, stamps added by previous middlewares in the stack are dropped. What this means in practice is:bin/console messenger:consume --bus=externalreceives a message andAddBusNameStampMiddlewareadds theBusNameStampso that in case of failure it would be routed to a correct busBusNameStampis sent to failure queuebin/console messenger:failed:retry, the message is dispatched on wrong bus (the default one)This has really bad implications if you handle the message differently depending on which bus it is received.
Some refactoring was done to reduce duplication, similar to
WrappedExceptionsTrait/WrappedExceptionsInterface.