Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix exception thrown duringLDAP_MODIFY_BATCH_REMOVE_ALL batch operations#54839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.4fromunknown repositoryMay 4, 2024
Merged

Fix exception thrown duringLDAP_MODIFY_BATCH_REMOVE_ALL batch operations#54839

fabpot merged 1 commit intosymfony:5.4fromunknown repositoryMay 4, 2024

Conversation

@ghost
Copy link

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
IssuesFix#54829
LicenseMIT

Bugfix removesvalues array element forLDAP_MODIFY_BATCH_REMOVE_ALL operations. PHP throws an exception when this element is included.

Testing this component is complicated by the fact that most tests are skipped unless there's a local LDAP server running. To create a test which demonstrated the issue and fix, I created a default GitHub Codespace and ran the attached shell commands. These commands install and configure a local OpenLDAP server. You'll probably need to do something similar to confirm the issue/fix.

setup-ldap-codespace.md

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "7.1" but it seems your PR description refers to branch "5.4".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@ghost ghost changed the base branch from7.1 to5.4May 4, 2024 07:16
@ghostghost changed the titleFix 54829[Ldap] Fix 54829May 4, 2024
@ghostghost changed the title[Ldap] Fix 54829[Ldap] Fix exception thrown duringLDAP_MODIFY_BATCH_REMOVE_ALL batch operationsMay 4, 2024
Copy link
Member

@xabbuhxabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@carsonbotcarsonbot changed the title[Ldap] Fix exception thrown duringLDAP_MODIFY_BATCH_REMOVE_ALL batch operationsFix exception thrown duringLDAP_MODIFY_BATCH_REMOVE_ALL batch operationsMay 4, 2024
@fabpotfabpot modified the milestones:7.1,5.4May 4, 2024
@fabpot
Copy link
Member

Thank you @phasdev.

@fabpotfabpot merged commitddf3489 intosymfony:5.4May 4, 2024
@ghost ghost deleted the fix_54829 branchMay 6, 2024 16:05
@fabpotfabpot mentioned this pull requestMay 17, 2024
This was referencedJun 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

[Ldap] UpdateOperation toArray() function throws exception when using LDAP_MODIFY_BATCH_REMOVE_ALL operation type

3 participants

@carsonbot@fabpot@xabbuh
[8]ページ先頭
©2009-2025 Movatter.jp