Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Mailer] [Sendgrid] UseDataPart::getContentId() whenDataPart::setContentId() is used#54837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@SherinBloemendaal
Copy link
Contributor

QA
Branch?6.4
Bug fix?yes
New feature?no
Deprecations?no
IssuesSee bellow
LicenseMIT

Fixes the content identifier set viaDataPart::setContentId() not being respected. Instead the$filename of theDataPart was being used resulting in unexpected behaviour. To provide backwards compatibility theDataPart::hasContentId() is being used to keep the current behaviour.

Applied to 6.4 sinceDataPart::setContentId() was introduced in 6.2.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbotcarsonbot changed the title[Mailer][Sendgrid] Use DataPart::getContentId() when DataPart::setContentId() is used.[Mailer] [Sendgrid] Use DataPart::getContentId() when DataPart::setContentId() is used.May 3, 2024
@SherinBloemendaalSherinBloemendaalforce-pushed thesendgrid-inline-content-identifier branch from4b3f2ff to1211fbeCompareMay 3, 2024 16:55
Copy link
Contributor

@OskarStarkOskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

SherinBloemendaal reacted with rocket emoji
@OskarStarkOskarStark changed the title[Mailer] [Sendgrid] Use DataPart::getContentId() when DataPart::setContentId() is used.[Mailer] [Sendgrid] Use DataPart::getContentId() when DataPart::setContentId() is usedMay 6, 2024
@OskarStarkOskarStark changed the title[Mailer] [Sendgrid] Use DataPart::getContentId() when DataPart::setContentId() is used[Mailer] [Sendgrid] UseDataPart::getContentId() whenDataPart::setContentId() is usedMay 6, 2024
@fabpot
Copy link
Member

Thank you@SherinBloemendaal.

SherinBloemendaal reacted with heart emoji

@fabpotfabpot merged commit68ffeba intosymfony:6.4May 7, 2024
@SherinBloemendaalSherinBloemendaal deleted the sendgrid-inline-content-identifier branchMay 7, 2024 06:13
@fabpotfabpot mentioned this pull requestMay 17, 2024
This was referencedJun 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

@xabbuhxabbuhxabbuh approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

5 participants

@SherinBloemendaal@carsonbot@fabpot@OskarStark@xabbuh
[8]ページ先頭
©2009-2025 Movatter.jp