Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[DoctrineBridge] fix setting validated fields not using the options array#54835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedMay 3, 2024
| Q | A |
|---|---|
| Branch? | 7.1 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Issues | |
| License | MIT |
| publicfunctiontestValidateDTOUniqueness() | ||
| { | ||
| $constraint =newUniqueEntity( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The body of those tests is the same, only constraint is different. ThedataProvider should be used. This approach is already used in theUniqueEntityValidatorTest::provideConstraintsWithCustomRepositoryMethod.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I wrote the tests this way on purpose so that we don't have to rewrite them for Symfony 7.2 in#54744