Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpClient] Fix cURL default options for PHP 8.4#54830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
derrabus merged 1 commit intosymfony:5.4fromalexandre-daubois:curl-nullable
May 3, 2024

Conversation

alexandre-daubois
Copy link
Member

@alexandre-dauboisalexandre-daubois commentedMay 3, 2024•
edited
Loading

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
Issues-
LicenseMIT

PHP 8.4 brings a change in ext/curl (php/php-src#13291) that requiresCurlResponse to be updated. Curl callbacks cannot be set to null anymore and requires real callable.

Here is (one of) the CI error it fixes:

10) Symfony\Component\HttpClient\Tests\CurlHttpClientTest::testGzipBrokenFailed asserting that exception of type "TypeError" matches expected exception "Symfony\Contracts\HttpClient\Exception\TransportExceptionInterface". Message was: "curl_setopt_array(): Argument #2 ($options) must be a valid callback for option CURLOPT_PROGRESSFUNCTION, no array or string given" at/home/runner/work/symfony/symfony/src/Symfony/Component/HttpClient/Response/CurlResponse.php:175/home/runner/work/symfony/symfony/src/Symfony/Component/HttpClient/Internal/Canary.php:32/home/runner/work/symfony/symfony/src/Symfony/Component/HttpClient/Response/TransportResponseTrait.php:90/home/runner/work/symfony/symfony/src/Symfony/Component/HttpClient/Response/TransportResponseTrait.php:218/home/runner/work/symfony/symfony/src/Symfony/Component/HttpClient/Response/CommonResponseTrait.php:68/home/runner/work/symfony/symfony/src/Symfony/Component/HttpClient/Response/CurlResponse.php:232/home/runner/work/symfony/symfony/src/Symfony/Contracts/HttpClient/Test/HttpClientTestCase.php:1113

@carsonbot

This comment was marked as resolved.

@alexandre-dauboisalexandre-daubois changed the base branch from7.1 to5.4May 3, 2024 08:34
@xabbuhxabbuh modified the milestones:7.1,5.4May 3, 2024
@xabbuh
Copy link
Member

seehttps://github.com/symfony/symfony/actions/runs/8936565926/job/24547155340?pr=54832#step:8:2947 for how it looks like without these changes

alexandre-daubois reacted with heart emoji

@derrabusderrabus changed the title[HttpClient] Fix cURL default options[HttpClient] Fix cURL default options for PHP 8.4May 3, 2024
@derrabus
Copy link
Member

Thank you@alexandre-daubois.

@derrabusderrabus merged commit52099f9 intosymfony:5.4May 3, 2024
7 of 10 checks passed
nicolas-grekas added a commit that referenced this pull requestMay 13, 2024
…-daubois)This PR was merged into the 5.4 branch.Discussion----------[HttpClient] Revert fixing curl default options| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Issues        | -| License       | MITReverts#54830 becausephp/php-src#14165 got merged and fixes the unintentional BC break.(CI still red but should go to green when new nightlies are built)Commits-------365f7b4 [HttpClient] Revert fixing curl default options
@fabpotfabpot mentioned this pull requestMay 17, 2024
This was referencedJun 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@derrabusderrabusderrabus approved these changes

@xabbuhxabbuhxabbuh approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

4 participants
@alexandre-daubois@carsonbot@xabbuh@derrabus
[8]ページ先頭
©2009-2025 Movatter.jp