NotificationsYou must be signed in to change notification settings
Fork9.6k
Star30.4k

[HttpKernel] Support variadic with`#[MapRequestPayload]`#54817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

DjordyKoert wants to merge1 commit intosymfony:7.4

base:7.4

Choose a base branch

fromDjordyKoert:map-request-payload-variadic

Open

[HttpKernel] Support variadic with`#[MapRequestPayload]`#54817

DjordyKoert wants to merge1 commit intosymfony:7.4fromDjordyKoert:map-request-payload-variadic

+45 −4

Conversation

Copy link

Contributor

DjordyKoert commentedMay 2, 2024•
edited by nicolas-grekas
Loading

Q	A
Branch?	7.2
Bug fix?	no
New feature?	yes
Deprecations?	no
Issues	-
License	MIT

Adds support for variadic arguments in combination with#[MapRequestPayload].

Example request

Content-Type: application/json[    {"price":50},    {"price":23}]

Example controller usage

class MyController{publicfunction__invoke(        #[MapRequestPayload]Price ...$prices,    ):Response {// do something with $prices -> array<Price>    }}

This PR also fixes a bug introduced in#49978 where using#[MapUploadedFile] with a variadic argument causes aTypeError:

class MyController{publicfunction__invoke(        #[MapUploadedFile]UploadedFile ...$documents,    ):Response {    }}

Argument #1 must be of type Symfony\\Component\\HttpFoundation\\File\\UploadedFile, array given

carsonbot added Status: Needs Review Feature HttpKernel labels

May 2, 2024

carsonbot added this to the7.1 milestone

May 2, 2024

Copy link

carsonbot commentedMay 2, 2024

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot