Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[ExpressionLanguage] Support non-existent names when followed by null coalescing#54757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[ExpressionLanguage] Support non-existent names when followed by null coalescing#54757
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedApr 28, 2024
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
src/Symfony/Component/ExpressionLanguage/Node/NullCoalescedNameNode.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
OskarStark commentedApr 29, 2024
To me this a new feature, please add an entry in the changeling for 7.2 section, as we are in feature freeze for 7.1, thanks |
Uh oh!
There was an error while loading.Please reload this page.
adamkiss commentedApr 29, 2024
Shame about the feature freeze. will do. |
3a3dfdd to3c620dcComparefabpot commentedMay 31, 2024
Thank you@adamkiss. |
Uh oh!
There was an error while loading.Please reload this page.
This PR allows for null coalescing nonexistent names (
nonexistent ?? 123) in expressions by introducing new type of nodeNullCoalescedNameNode, which compiles to$nonexistent ?? null, so it subsequently evaluates to null and the null coalescing takes over then.Edit: feature/bug is questionable, because I half-consider it a bug, since it'sone of the examples in the docs, despite my original issue being closed as "expected", and the docs issue marked resolved despite this use case throwing while existing names resolving to null pass.