Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[ExpressionLanguage] Support non-existent names when followed by null coalescing#54757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@adamkiss
Copy link
Contributor

@adamkissadamkiss commentedApr 28, 2024
edited by OskarStark
Loading

QA
Branch?7.2
Bug fix?no
New feature?yes
IssuesFix#54359
LicenseMIT

This PR allows for null coalescing nonexistent names (nonexistent ?? 123) in expressions by introducing new type of nodeNullCoalescedNameNode, which compiles to$nonexistent ?? null, so it subsequently evaluates to null and the null coalescing takes over then.

Edit: feature/bug is questionable, because I half-consider it a bug, since it'sone of the examples in the docs, despite my original issue being closed as "expected", and the docs issue marked resolved despite this use case throwing while existing names resolving to null pass.

jseparovic1 reacted with thumbs up emoji
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@OskarStarkOskarStark modified the milestones:7.1,7.2Apr 29, 2024
@OskarStark
Copy link
Contributor

To me this a new feature, please add an entry in the changeling for 7.2 section, as we are in feature freeze for 7.1, thanks

adamkiss reacted with thumbs up emoji

@adamkiss
Copy link
ContributorAuthor

To me this a new feature, please add an entry in the changeling for 7.2 section, as we are in feature freeze for 7.1, thanks

Shame about the feature freeze. will do.

OskarStark reacted with laugh emoji

@fabpotfabpotforce-pushed thefeat-null-coalescing-nonexistent-names branch from3a3dfdd to3c620dcCompareMay 31, 2024 06:30
@fabpot
Copy link
Member

Thank you@adamkiss.

adamkiss reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@OskarStarkOskarStarkOskarStark left review comments

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

7.2

Development

Successfully merging this pull request may close these issues.

[Expression Language] Null coalescing operator doesn't work?

6 participants

@adamkiss@carsonbot@OskarStark@fabpot@nicolas-grekas@xabbuh

[8]ページ先頭

©2009-2025 Movatter.jp