Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Serializer] AddXmlEncoder::CDATA_WRAPPING_PATTERN context option#54663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@alexpozzi
Copy link
Contributor

@alexpozzialexpozzi commentedApr 18, 2024•
edited by nicolas-grekas
Loading

QA
Branch?7.1
Bug fix?no
New feature?yes
Deprecations?no
IssuesFix#54155
LicenseMIT

First of all thank you for all your hard work!

This PR adds the ability to configure the CDATA wrapping pattern to give more flexibility on when to wrap values in a CDATA section.
For example, XML validators are not allowing double and single quotes outside of a CDATA section, with this change we could be able to change the pattern from/[<>&]/ to/[<>&"\']/ and solve that issue without the need of writing a custom XMLEncoder.

AndoniLarz reacted with thumbs up emoji
@carsonbotcarsonbot added this to the7.1 milestoneApr 18, 2024
@alexpozzialexpozziforce-pushed theissue-54155/add-the-ability-to-confiure-cdata-wrapper-pattern branch 4 times, most recently from39f0428 to105a952CompareApril 18, 2024 14:55
@OskarStarkOskarStark changed the title[Serializer] Add XmlEncoder::CDATA_WRAPPING_PATTERN context option[Serializer] AddXmlEncoder::CDATA_WRAPPING_PATTERN context optionApr 19, 2024
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please fix@OskarStark's comments and GTM, thanks.

@fabpotfabpot modified the milestones:7.1,7.2Apr 27, 2024
@alexpozzialexpozziforce-pushed theissue-54155/add-the-ability-to-confiure-cdata-wrapper-pattern branch 2 times, most recently from5e25e13 to06ccf50CompareApril 29, 2024 06:29
@alexpozzi
Copy link
ContributorAuthor

Hello@nicolas-grekas,
I'm not so sure to understand what you mean by GTM.
I fixed the comments and rebased to the latest 7.1 commit.

@alexpozzialexpozziforce-pushed theissue-54155/add-the-ability-to-confiure-cdata-wrapper-pattern branch from06ccf50 to43e0750CompareApril 29, 2024 06:33
@OskarStark
Copy link
Contributor

GTM = Good to me 😃

alexpozzi reacted with thumbs up emoji

@alexpozzialexpozziforce-pushed theissue-54155/add-the-ability-to-confiure-cdata-wrapper-pattern branch from43e0750 to129bb3fCompareApril 29, 2024 11:40
@alexpozzialexpozziforce-pushed theissue-54155/add-the-ability-to-confiure-cdata-wrapper-pattern branch 2 times, most recently from8b5f95c to8edf532CompareApril 30, 2024 10:26
@alexpozzialexpozziforce-pushed theissue-54155/add-the-ability-to-confiure-cdata-wrapper-pattern branch from8edf532 to8ab57d1CompareApril 30, 2024 15:28
@nicolas-grekasnicolas-grekas modified the milestones:7.2,7.1May 2, 2024
@fabpot
Copy link
Member

Thank you@alexpozzi.

alexpozzi reacted with heart emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

+1 more reviewer

@clementvtrdclementvtrdclementvtrd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

7.1

Development

Successfully merging this pull request may close these issues.

[Serializer] Add XmlEncoder::CDATA_WRAPPING_PATTERN context option

6 participants

@alexpozzi@OskarStark@fabpot@nicolas-grekas@clementvtrd@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp