Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[TwigBundle] Deprecatebase_template_class option#54657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:7.1fromSteveb-p:patch-1
May 2, 2024
Merged

[TwigBundle] Deprecatebase_template_class option#54657

fabpot merged 1 commit intosymfony:7.1fromSteveb-p:patch-1
May 2, 2024

Conversation

@Steveb-p
Copy link
Contributor

QA
Branch?7.1
Bug fix?no
New feature?no
Deprecations?yes
Issues
LicenseMIT

According tohttps://github.com/twigphp/Twig/blob/3.x/CHANGELOG#L222,base_template_class option has been removed from Twig 3.0.

Symfony still allows to pass this configuration option viahttps://github.com/symfony/symfony/blob/7.1/src/Symfony/Bundle/TwigBundle/DependencyInjection/Configuration.php#L132, but there is of course no effect.

I think it would be good to deprecate it and prepare it's removal in 8.x? Since Symfony 7.x requires Twig 3.x.

alongosz reacted with thumbs up emoji
@xabbuh
Copy link
Member

xabbuh commentedApr 18, 2024•
edited
Loading

The deprecation should be documented inUPRADE-7.1.md and in the changelog file of TwigBundle though.

@Steveb-p
Copy link
ContributorAuthor

Steveb-p commentedApr 18, 2024•
edited
Loading

The deprecation should be documented inUPRADE-7.1.md and in the changelog file of TwigBundle though.

I will follow up with this shortly 😅 I just need to check how they are usually done :)

xabbuh reacted with thumbs up emoji

@carsonbotcarsonbot changed the titleDeprecate Twig Bundlebase_template_class option[TwigBundle] Deprecate Twig Bundlebase_template_class optionApr 19, 2024
@OskarStarkOskarStark changed the title[TwigBundle] Deprecate Twig Bundlebase_template_class option[TwigBundle] Deprecatebase_template_class optionApr 19, 2024
@fabpot
Copy link
Member

Thank you@Steveb-p.

@derrabus
Copy link
Member

The tests needed a little adjustment:#54810

xabbuh reacted with thumbs up emoji

nicolas-grekas added a commit that referenced this pull requestMay 2, 2024
…e_class (derrabus)This PR was merged into the 7.1 branch.Discussion----------[TwigBundle] Fix deprecation warnings about base_template_class| Q             | A| ------------- | ---| Branch?       | 7.1| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Issues        | Follows#54657| License       | MITSince#54657, TwigBundle uses its own deprecated option in non-legacy tests. This PR fixes this by testing that option and the triggered deprecation message in a separate test.Commits-------10d48cd [TwigBundle] Fix deprecation warnings about base_template_class
@fabpotfabpot mentioned this pull requestMay 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@stofstofstof approved these changes

@xabbuhxabbuhxabbuh approved these changes

@ycerutoycerutoAwaiting requested review from ycerutoyceruto is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

7.1

Development

Successfully merging this pull request may close these issues.

7 participants

@Steveb-p@xabbuh@fabpot@derrabus@stof@OskarStark@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp