Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[PasswordHasher] Skip test assertions that are no longer valid with PHP >= 8.2.18/8.3.5#54587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.4fromxabbuh:bcrypt-null-password
Apr 14, 2024

Conversation

@xabbuh
Copy link
Member

@xabbuhxabbuh commentedApr 13, 2024•
edited
Loading

QA
Branch?5.4
Bug fix?no
New feature?no
Deprecations?no
Issues
LicenseMIT

seephp/php-src@0ba5229 andhttps://3v4l.org/9QigI

@xabbuhxabbuh requested a review fromchalasr as acode ownerApril 13, 2024 07:05
@carsonbotcarsonbot added this to the5.4 milestoneApr 13, 2024
@carsonbotcarsonbot changed the title[PasswordHasher] fix tests that are no longer valid with PHP >= 8.2.18/8.3.5[PasswordHasher]  fix tests that are no longer valid with PHP >= 8.2.18/8.3.5Apr 13, 2024
@xabbuhxabbuh changed the title[PasswordHasher]  fix tests that are no longer valid with PHP >= 8.2.18/8.3.5[PasswordHasher]  skip tests that are no longer valid with PHP >= 8.2.18/8.3.5Apr 13, 2024
@xabbuhxabbuhforce-pushed thebcrypt-null-password branch 2 times, most recently from6c1c53e to20cd73fCompareApril 13, 2024 17:56
@xabbuhxabbuh changed the title[PasswordHasher]  skip tests that are no longer valid with PHP >= 8.2.18/8.3.5[PasswordHasher]  skip test assertions that are no longer valid with PHP >= 8.2.18/8.3.5Apr 13, 2024
@xabbuh
Copy link
MemberAuthor

I updated the message according to@fabpot's suggestion. While at it I also realised that we shouldn't the skip the whole tests but also a single assertion that no longer works. InsideNativePasswordHasher we already work around the limitation of bcrypt since#40920.

@OskarStarkOskarStark changed the title[PasswordHasher]  skip test assertions that are no longer valid with PHP >= 8.2.18/8.3.5[PasswordHasher] Skip test assertions that are no longer valid with PHP >= 8.2.18/8.3.5Apr 13, 2024
@fabpot
Copy link
Member

Thank you@xabbuh.

@fabpotfabpot merged commit6a1c9ae intosymfony:5.4Apr 14, 2024
@xabbuhxabbuh deleted the bcrypt-null-password branchApril 14, 2024 08:01
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

@derrabusderrabusderrabus approved these changes

@chalasrchalasrAwaiting requested review from chalasrchalasr is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

6 participants

@xabbuh@fabpot@OskarStark@derrabus@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp