Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Mailer] [Resend] Add Resend webhook signature verification#54525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@welcoMattic
Copy link
Member

QA
Branch?7.1
Bug fix?no
New feature?yes
Deprecations?no
IssuesFix#53554
LicenseMIT

Follow up of#53554. At this time I missed webhook signature verification. To complete the Bridge before 7.1 release, here it is!

I plan to add more webhook payloads in test, I asked Resend to send me example, because some are tough to reproduce.

@welcoMatticwelcoMattic added the ❄️ Feature FreezeImportant Pull Requests to finish before the next Symfony "feature freeze" labelApr 8, 2024
@carsonbotcarsonbot changed the title[Mailer][Resend] Add Resend webhook signature verification[Resend] Add Resend webhook signature verificationApr 8, 2024
@carsonbotcarsonbot added this to the7.1 milestoneApr 8, 2024
@carsonbotcarsonbot changed the title[Resend] Add Resend webhook signature verification[Mailer] [Resend] Add Resend webhook signature verificationApr 8, 2024
@welcoMatticwelcoMatticforce-pushed themailer-resend-webhook-verification branch from3881e5e toeede9c5CompareApril 8, 2024 14:59
@welcoMattic
Copy link
MemberAuthor

Unrelated tests failures

@welcoMatticwelcoMatticforce-pushed themailer-resend-webhook-verification branch from9d8357b toe951137CompareApril 17, 2024 12:30
@welcoMatticwelcoMattic changed the title[Mailer] [Resend] Add Resend webhook signature verification[Mailer][Resend] Add Resend webhook signature verificationApr 17, 2024
Copy link
Member

@fabpotfabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Are you still waiting for more test payloads?

@welcoMattic
Copy link
MemberAuthor

@fabpot I was waiting for this first one, I'm quite confident about this one and the signature verification code (I get it from the officialResend PHP SDK). Can we merge as it is, and add more webhook tests later if needed?

@carsonbotcarsonbot changed the title[Mailer][Resend] Add Resend webhook signature verification[Mailer] [Resend] Add Resend webhook signature verificationApr 17, 2024
@fabpotfabpotforce-pushed themailer-resend-webhook-verification branch frome951137 to8daa804CompareApril 17, 2024 12:59
@fabpot
Copy link
Member

Thank you@welcoMattic.

@fabpotfabpot merged commit9ec8b7c intosymfony:7.1Apr 17, 2024
@welcoMatticwelcoMattic deleted the mailer-resend-webhook-verification branchApril 17, 2024 12:59
@fabpotfabpot mentioned this pull requestMay 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasAwaiting requested review from nicolas-grekas

@OskarStarkOskarStarkAwaiting requested review from OskarStark

+1 more reviewer

@norkunasnorkunasnorkunas left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

FeatureMailer❄️ Feature FreezeImportant Pull Requests to finish before the next Symfony "feature freeze"Status: Reviewed

Projects

None yet

Milestone

7.1

Development

Successfully merging this pull request may close these issues.

4 participants

@welcoMattic@fabpot@norkunas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp