Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Remove redundant type in@param occurrences#54523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
2965716 tof94d36eCompareUh oh!
There was an error while loading.Please reload this page.
f94d36e to7e232b2Comparederrabus commentedApr 8, 2024
How's tool support for this syntax these days? |
alexandre-daubois commentedApr 9, 2024
Am I missing something? I'd be happy to test more! |
nicolas-grekas commentedApr 12, 2024
Please allow me to close here as this would need some automation to enforce in the long run. At the moment, this isn't worth the review+conflict-resolution time this will create IMHO. |
alexandre-daubois commentedApr 12, 2024
Fair enough 👍 |
Uh oh!
There was an error while loading.Please reload this page.
This decision was stated in many places,here is the most recent (I guess).
A Rector rule did the job, however it was not accepted in the upstream:
RemoveUselessTypeInParamTagRectorrule rectorphp/rector-src#5811Still I applied it + PHP CS Fixer
phpdoc_alignwithverticalto get this result. Finally, an issue has been reported to Jetbrains so PHPStorm may supports this syntax:https://youtrack.jetbrains.com/issue/WI-76947/Allow-param-to-omit-the-type. 🤞