Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Remove redundant type in@param occurrences#54523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@alexandre-daubois
Copy link
Member

@alexandre-dauboisalexandre-daubois commentedApr 8, 2024
edited
Loading

QA
Branch?7.1
Bug fix?no
New feature?no
Deprecations?no
Issues-
LicenseMIT

This decision was stated in many places,here is the most recent (I guess).

A Rector rule did the job, however it was not accepted in the upstream:

Still I applied it + PHP CS Fixerphpdoc_align withvertical to get this result. Finally, an issue has been reported to Jetbrains so PHPStorm may supports this syntax:https://youtrack.jetbrains.com/issue/WI-76947/Allow-param-to-omit-the-type. 🤞

@derrabus
Copy link
Member

How's tool support for this syntax these days?

@alexandre-daubois
Copy link
MemberAuthor

  • PHPStorm struggles with this, hope my issue in Jetbrains' Youtrack gets some attention!
  • Psalm seems ok, as it didn't complain in this PR
  • PHPStan handles it well:https://phpstan.org/r/e471345c-3f0b-4a71-a593-c72639017700
  • phpDocumentor defines the type as optional so it's also fine
  • VSCode seems also fine with it

Am I missing something? I'd be happy to test more!

@nicolas-grekas
Copy link
Member

Please allow me to close here as this would need some automation to enforce in the long run. At the moment, this isn't worth the review+conflict-resolution time this will create IMHO.

@alexandre-daubois
Copy link
MemberAuthor

Fair enough 👍

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@GromNaNGromNaNGromNaN left review comments

@xabbuhxabbuhAwaiting requested review from xabbuhxabbuh is a code owner

@lyrixxlyrixxAwaiting requested review from lyrixxlyrixx is a code owner

@ycerutoycerutoAwaiting requested review from ycerutoyceruto is a code owner

@welcoMatticwelcoMatticAwaiting requested review from welcoMatticwelcoMattic is a code owner

@kbondkbondAwaiting requested review from kbondkbond is a code owner

@chalasrchalasrAwaiting requested review from chalasrchalasr is a code owner

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

@OskarStarkOskarStarkAwaiting requested review from OskarStarkOskarStark is a code owner

@jderussejderusseAwaiting requested review from jderussejderusse is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

7.1

Development

Successfully merging this pull request may close these issues.

5 participants

@alexandre-daubois@derrabus@nicolas-grekas@GromNaN@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp