Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Contracts] Rename ServiceSubscriberTrait to ServiceMethodsSubscriberTrait#54496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
fabpot merged 1 commit intosymfony:7.1fromnicolas-grekas:service-methods-subscriber-traitApr 5, 2024
Merged
[Contracts] Rename ServiceSubscriberTrait to ServiceMethodsSubscriberTrait#54496
fabpot merged 1 commit intosymfony:7.1fromnicolas-grekas:service-methods-subscriber-traitApr 5, 2024
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
7f17197 tocaaa488Comparestof requested changesApr 5, 2024
Uh oh!
There was an error while loading.Please reload this page.
caaa488 to8f47cedComparestof approved these changesApr 5, 2024
Member
fabpot commentedApr 5, 2024
Thank you@nicolas-grekas. |
Contributor
MatTheCat commentedApr 9, 2024
This PR seems to break the |
Member
xabbuh commentedApr 9, 2024
@MatTheCat fixed now after the sub-tree split for the service contracts was synchronised |
Uh oh!
There was an error while loading.Please reload this page.
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull requestApr 10, 2024
…ated and replaced by `ServiceMethodsSubscriberTrait` (GromNaN)This PR was merged into the 7.1 branch.Discussion----------[DependencyInjection] `ServiceSubscriberTrait` is deprecated and replaced by `ServiceMethodsSubscriberTrait`Fix#19755Related code change:symfony/symfony#54496Commits-------f17331c ServiceSubscriberTrait is deprecated and replaced by ServiceMethodsSubscriberTrait
Merged
xabbuh added a commit that referenced this pull requestOct 10, 2024
This PR was merged into the 7.1 branch.Discussion----------[Contracts] add missing properties| Q | A| ------------- | ---| Branch? | 7.1| Bug fix? | no| New feature? | no| Deprecations? | no| Issues || License | MITSince#54496 the property is no longer part of the `ServiceSubscriberTrait` triggering a PHP deprecation like:> Creation of dynamic property Symfony\Contracts\Tests\Service\LegacyTestService::$container is deprecatedCommits-------fbfeefe add missing properties
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
As described in the linked PR, AbstractController is incompatible with ServiceSubscriberTrait because of the added type to the AbstractController::$container property, while ServiceSubscriberTrait's $container property cannot have a type without a BC break.
There are two parts to this PR:
trait will create a dynamic property. Those are deprecated, but since the trait is also deprecated, the upgrade path is clear.
I also tried to improve the description of the trait in the meantime.
/cc@kbond