Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[DependencyInjection] Document BC break in UPGRADE file#54481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:7.1fromOskarStark:upgrade
Apr 5, 2024

Conversation

@OskarStark
Copy link
Contributor

QA
Branch?7.1
Bug fix?no
New feature?no
Deprecations?no
IssuesFollows#52843
LicenseMIT

yceruto reacted with thumbs up emoji
@carsonbotcarsonbot added this to the7.1 milestoneApr 3, 2024
@OskarStarkOskarStark added the ❄️ Feature FreezeImportant Pull Requests to finish before the next Symfony "feature freeze" labelApr 3, 2024
Copy link
Member

@ycerutoyceruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Oskar shouldn't the file to be updated beUPGRADE-7.1.md instead?

@OskarStark
Copy link
ContributorAuthor

You are right, I picked the wrong one 😅

@OskarStarkOskarStark requested a review fromycerutoApril 4, 2024 14:10
Copy link
Member

@ycerutoyceruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks Oskar!

OskarStark and asrorbekh reacted with heart emoji
@fabpot
Copy link
Member

Sorry, I'm late in the game here, but what is the rationale behind doing a BC break in 7.1?

@yceruto
Copy link
Member

Sorry, I'm late in the game here, but what is the rationale behind doing a BC break in 7.1?

Hey Fabien, we published this as a BC break because technically it is (we changed the behavior of theimport() method under certain context/scope without deprecation path). However, actually, nobody can/should use theimport() method in theprependExtension() because it's defective, appending config instead of prepending. That's why we were using theContainerBuilder::prependExtensionConfig() until now (which is limited to anarray of config).

Honestly, this BC break, in the end, doesn't feel like a real BC break to me, as the previous behavior was faulty and unwanted. However, it applies to the BC break rules, so we are documenting it as such.

More details can be found here#52789 and here#52843

Hope it's ok for you🤞

@fabpot
Copy link
Member

Sorry, I'm late in the game here, but what is the rationale behind doing a BC break in 7.1?

Hey Fabien, we published this as a BC break because technically it is (we changed the behavior of theimport() method under certain context/scope without deprecation path). However, actually, nobody can/should use theimport() method in theprependExtension() because it's defective, appending config instead of prepending. That's why we were using theContainerBuilder::prependExtensionConfig() until now (which is limited to anarray of config).

Honestly, this BC break, in the end, doesn't feel like a real BC break to me, as the previous behavior was faulty and unwanted. However, it applies to the BC break rules, so we are documenting it as such.

More details can be found here#52789 and here#52843

Hope it's ok for you🤞

Thank you for the clear explanation, that makes sense to me now.

yceruto reacted with heart emoji

@fabpot
Copy link
Member

Thank you@OskarStark.

OskarStark reacted with heart emoji

@fabpotfabpot merged commitc35173c intosymfony:7.1Apr 5, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@xabbuhxabbuhxabbuh approved these changes

@ycerutoycerutoyceruto approved these changes

Assignees

No one assigned

Labels

DependencyInjection❄️ Feature FreezeImportant Pull Requests to finish before the next Symfony "feature freeze"Status: Reviewed

Projects

None yet

Milestone

7.1

Development

Successfully merging this pull request may close these issues.

5 participants

@OskarStark@fabpot@yceruto@xabbuh@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp