Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Emoji] Add the "text" locale#54470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:7.1fromnicolas-grekas:emoji-fix
Apr 5, 2024
Merged

Conversation

@nicolas-grekas
Copy link
Member

@nicolas-grekasnicolas-grekas commentedApr 3, 2024•
edited
Loading

QA
Branch?7.1
Bug fix?no
New feature?no
Deprecations?no
Issues-
LicenseMIT
  • Adding the "text" locale, which is a merge from slack+github+gitlab maps
  • Fixes the gitlab maps which were missing aliases and combined emojis
  • Ordering the github/gitlab/slack maps so that we can compare them
  • Fixing a typo
  • Removing a needless check that prevents listing '🙂‍↔' => 'head shaking horizontally',
  • Simplifying the build script a bit

alamirault reacted with thumbs up emoji
Copy link
Member

@lyrixxlyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

A minor question, otherwise 👍🏼

@nicolas-grekasnicolas-grekasforce-pushed theemoji-fix branch 3 times, most recently fromd195dcd tocb69d3fCompareApril 3, 2024 11:47
@nicolas-grekasnicolas-grekasforce-pushed theemoji-fix branch 2 times, most recently from903606c to2581839CompareApril 4, 2024 08:25
@nicolas-grekasnicolas-grekas changed the title[Emoji] More ordering and minor fixes[Emoji] Add the "text" localeApr 4, 2024
@nicolas-grekas
Copy link
MemberAuthor

nicolas-grekas commentedApr 4, 2024•
edited
Loading

PR updated to add a new "text" locale, which uses a map resulting from merging slack+github+gitlab maps.
This also fixes the gitlab maps, which were missing combined emojis and aliases.

@lyrixx
Copy link
Member

PR updated to add a new "text" locale, which uses a map resulting from merging slack+github+gitlab maps.

love it!

@nicolas-grekasnicolas-grekas added the ❄️ Feature FreezeImportant Pull Requests to finish before the next Symfony "feature freeze" labelApr 4, 2024
Copy link
Member

@lyrixxlyrixx left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍🏼 Thanks

@fabpot
Copy link
Member

Thank you@nicolas-grekas.

@fabpotfabpot merged commit220b5bc intosymfony:7.1Apr 5, 2024
@nicolas-grekasnicolas-grekas deleted the emoji-fix branchApril 5, 2024 09:46
@fabpotfabpot mentioned this pull requestMay 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof left review comments

@fabpotfabpotfabpot approved these changes

@lyrixxlyrixxlyrixx approved these changes

+1 more reviewer

@smnandresmnandresmnandre left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Emoji❄️ Feature FreezeImportant Pull Requests to finish before the next Symfony "feature freeze"Status: Reviewed

Projects

None yet

Milestone

7.1

Development

Successfully merging this pull request may close these issues.

6 participants

@nicolas-grekas@lyrixx@fabpot@stof@smnandre@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp