Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[FrameworkBundle] Display aliases indebug:container command#54459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
fa98e0f to48be857Compare48be857 tof3e7977Compare| 'id' => (string)$value, | ||
| 'alias' =>$node->getValue()->getClass(), | ||
| ]; | ||
| }else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
no need for the "else"
nicolas-grekas commentedApr 3, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Arf, I'm sorry but looking at the implementation, this is a false promise. This doesn't show aliases but only the class of the source service. This works for services that use the id=fqcn convention, but that's inaccurate in the general case.
I don't know if we can reorder the passes to dump before resolving, but as is, this PR doesn't make sense to me. |
stof commentedApr 4, 2024
If we dump before resolving, we might end up missing other information in the debug commands by displaying the state before most compiler pass have run |
94noni commentedApr 4, 2024
@nicolas-grekas oki i got you, to be fair I've juste restarted it, blindly copy/pasting for now so the PR get visible |
Uh oh!
There was an error while loading.Please reload this page.
Note
This PR restarts the work achieved by@jlslew in#47427
as per#47427 (comment)
I do think this PR can give some valueable data (like one of my prev PR)
so I am continuing the work already done, to push it forward :)
I may need help/guidance for understanding the tests logic of such descriptor, as they are quite complicated :s