Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[FrameworkBundle] Display aliases indebug:container command#54459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

@94noni
Copy link
Contributor

@94noni94noni commentedApr 2, 2024
edited
Loading

QA
Branch?7.1
Bug fix?no
New feature?yes
Deprecations?no
IssuesRestart#47427
LicenseMIT

Note

This PR restarts the work achieved by@jlslew in#47427
as per#47427 (comment)

I do think this PR can give some valueable data (like one of my prev PR)
so I am continuing the work already done, to push it forward :)

I may need help/guidance for understanding the tests logic of such descriptor, as they are quite complicated :s


@94noni94noniforce-pushed theframework-debug-container-alias branch from48be857 tof3e7977CompareApril 2, 2024 17:32
'id' => (string)$value,
'alias' =>$node->getValue()->getClass(),
];
}else {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

no need for the "else"

@nicolas-grekas
Copy link
Member

nicolas-grekas commentedApr 3, 2024
edited
Loading

Arf, I'm sorry but looking at the implementation, this is a false promise. This doesn't show aliases but only the class of the source service. This works for services that use the id=fqcn convention, but that's inaccurate in the general case.

ContainerBuilderDebugDumpPass runsBEFORE_REMOVING which meansResolveReferencesToAliasesPass already ran and we lost the information that would be needed to achieve this.

I don't know if we can reorder the passes to dump before resolving, but as is, this PR doesn't make sense to me.

@stof
Copy link
Member

stof commentedApr 4, 2024

If we dump before resolving, we might end up missing other information in the debug commands by displaying the state before most compiler pass have run

@94noni
Copy link
ContributorAuthor

@nicolas-grekas oki i got you, to be fair I've juste restarted it, blindly copy/pasting for now so the PR get visible
if, for actual code in container, its not possible lets close as wontfix
thx

@94noni94noni closed thisApr 4, 2024
@94noni94noni deleted the framework-debug-container-alias branchAugust 8, 2024 10:51
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

Assignees

No one assigned

Projects

None yet

Milestone

7.1

Development

Successfully merging this pull request may close these issues.

4 participants

@94noni@nicolas-grekas@stof@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp