Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Clock] Add a polyfill for DateTimeImmutable::createFromTimestamp()#54442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@derrabus
Copy link
Member

QA
Branch?7.1
Bug fix?no
New feature?yes
Deprecations?no
IssuesN/A
LicenseMIT

This PR adds the newcreateFromTimestamp() method introduced inphp/php-src#12413 to ourDatePoint class. It comes with a polyfill implementation for PHP 8.2/8.3.

@derrabus
Copy link
MemberAuthor

derrabus commentedMar 30, 2024•
edited
Loading

I ignored fabbot's proposed exception message formatting because I'd like to stay close to the exception message generated by the upstream implementation.

@derrabusderrabusforce-pushed thefeature/create-from-timestamp branch from27a7fbb to7cf2d71CompareMarch 30, 2024 16:56
@derrabusderrabusforce-pushed thefeature/create-from-timestamp branch from7cf2d71 toe2e7ffaCompareApril 1, 2024 14:01
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good catch, I missed this one :)

@javiereguiluzjaviereguiluz added the ❄️ Feature FreezeImportant Pull Requests to finish before the next Symfony "feature freeze" labelApr 2, 2024
@derrabusderrabusforce-pushed thefeature/create-from-timestamp branch 3 times, most recently from7ca0fbd tocc1144dCompareApril 2, 2024 09:34
@derrabusderrabusforce-pushed thefeature/create-from-timestamp branch fromcc1144d to9e48e0dCompareApril 9, 2024 08:32
@derrabus
Copy link
MemberAuthor

Ready

@nicolas-grekas
Copy link
Member

Thank you@derrabus.

derrabus reacted with heart emoji

@nicolas-grekasnicolas-grekas merged commita8c43b6 intosymfony:7.1Apr 9, 2024
@derrabusderrabus deleted the feature/create-from-timestamp branchApril 9, 2024 09:01
@fabpotfabpot mentioned this pull requestMay 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@xabbuhxabbuhxabbuh left review comments

@javiereguiluzjaviereguiluzjaviereguiluz approved these changes

Assignees

No one assigned

Labels

ClockFeature❄️ Feature FreezeImportant Pull Requests to finish before the next Symfony "feature freeze"Status: Needs Review

Projects

None yet

Milestone

7.1

Development

Successfully merging this pull request may close these issues.

5 participants

@derrabus@nicolas-grekas@javiereguiluz@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp