Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Emoji] Add the gitlab locale#54441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@alamirault
Copy link
Contributor

@alamiraultalamirault commentedMar 30, 2024•
edited
Loading

QA
Branch?7.1
Bug fix?no
New feature?yes
Deprecations?no
IssuesFix #...
LicenseMIT

Gitlab has also its own emoji shortnames

https://docs.gitlab.com/ee/development/fe_guide/emojis.html

🤐
Github::zipper_mouth_face:
Gitlab::zipper_mouth:

(Like lyrixx, my most important PR of the year 😃 )

smnandre, lyrixx, asrorbekh, althaus, and xabbuh reacted with laugh emojipgrimaud reacted with heart emoji
Copy link
Member

@stofstof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Support forgitlab should also be added in theemojify Twig filter

@alamirault
Copy link
ContributorAuthor

Support forgitlab should also be added in theemojify Twig filter

With actual PR#54432, no change is required in filter to support new "locale"

lyrixx reacted with thumbs up emoji

nicolas-grekas added a commit that referenced this pull requestApr 2, 2024
This PR was squashed before being merged into the 7.1 branch.Discussion----------[Emoji] Update slack data| Q             | A| ------------- | ---| Branch?       | 7.1| Bug fix?      | no| New feature?  | no| Deprecations? | no| Issues        | -| License       | MITUpdate slack data to latest with make buildSplit#54441 in 2 PR as suggested in#54441 (comment)Commits-------1cc41cd [Emoji] Update slack data
@alamiraultalamirault requested a review fromstofApril 2, 2024 17:28
@stofstof added the ❄️ Feature FreezeImportant Pull Requests to finish before the next Symfony "feature freeze" labelApr 3, 2024
@nicolas-grekas
Copy link
Member

Thank you@alamirault.

@nicolas-grekasnicolas-grekas merged commitcce36cd intosymfony:7.1Apr 3, 2024
@alamiraultalamirault deleted the feature/gitlab-emoji branchApril 3, 2024 09:29
@fabpotfabpot mentioned this pull requestMay 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof approved these changes

@derrabusderrabusderrabus approved these changes

Assignees

No one assigned

Labels

EmojiFeature❄️ Feature FreezeImportant Pull Requests to finish before the next Symfony "feature freeze"Status: Reviewed

Projects

None yet

Milestone

7.1

Development

Successfully merging this pull request may close these issues.

5 participants

@alamirault@nicolas-grekas@stof@derrabus@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp