Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Console] Add of hidden and deprecation option flags#54439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:7.4
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Changes from1 commit
2cf5da9d203a4e4d86a4269b4bf8e2d3f12ece8b7aa08e4d502f0e0ed4be21854baa409a9ab17cda876fc615abe6602bb405ad7d4File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -19,6 +19,7 @@ | ||||||
| use Symfony\Component\Console\Exception\ExceptionInterface; | ||||||
| use Symfony\Component\Console\Exception\InvalidArgumentException; | ||||||
| use Symfony\Component\Console\Exception\LogicException; | ||||||
| use Symfony\Component\Console\Helper\FormatterHelper; | ||||||
| use Symfony\Component\Console\Helper\HelperInterface; | ||||||
| use Symfony\Component\Console\Helper\HelperSet; | ||||||
| use Symfony\Component\Console\Input\InputArgument; | ||||||
| @@ -275,7 +276,7 @@ public function run(InputInterface $input, OutputInterface $output): int | ||||||
| $input->validate(); | ||||||
| if (isset($inputDefinition)) { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. why the isset? Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more.
Author There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. As@GromNaN has already explained, Since Therefore, | ||||||
| $this->writeDeprecationMessages($inputDefinition, $input, $output); | ||||||
| } | ||||||
| if ($this->code) { | ||||||
| @@ -653,7 +654,7 @@ public function getHelper(string $name): HelperInterface | ||||||
| return $this->helperSet->get($name); | ||||||
| } | ||||||
| private functionwriteDeprecationMessages(InputDefinition $inputDefinition, InputInterface $input, OutputInterface $output): void | ||||||
| { | ||||||
| $deprecationMessages = []; | ||||||
| foreach ($inputDefinition->getOptions() as $inputOption) { | ||||||
| @@ -670,6 +671,7 @@ private function printDeprecationMessages(InputDefinition $inputDefinition, Inpu | ||||||
| } | ||||||
| } | ||||||
| if (!empty($deprecationMessages)) { | ||||||
flkasper marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||||||
| /** @var FormatterHelper $formatter */ | ||||||
| $formatter = $this->getHelper('formatter'); | ||||||
| $output->writeln($formatter->formatBlock($deprecationMessages, 'fg=black;bg=yellow', true)); | ||||||
| } | ||||||