Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

• Always add tests
• Keep backward compatibility (seehttps://symfony.com/bc).
• Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
• Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Waw very nice :)
Passing by, i would just split the PR commits into 2 separated PRs
Feature addition and cs fix on the other

@94noni I actually only wanted to fix my commit via ecs and had therefore limited ecs to the console bundle only.
Who would have thought that the code would differ in so many places :)

Got it :)
Lets wait other reviews 👌🏼

Love the idea... but i feel really agressed by the red, and i feel it makes the option an unwanted point of attention.

Did you try with other colors ? Something muted maybe to get the opposite effect ?

I think we should not relyonly on colors (for accessibility reasons but also technical ones),

What about an automatic[deprecated] prefix in the description ?

Options:    -test-deprecated            [deprecated] Lorem ipsum ...

With[deprecated] not having to be set in the option description

Love the idea... but i feel really agressed by the red, and i feel it makes the option an unwanted point of attention.
Did you try with other colors ? Something muted maybe to get the opposite effect ?

I had originally thought of yellow (warning), but this is already used in the headings such as "Options:".

I have now simply output in every available style and colour for comparison.
Personally, I think that yellow, gray and white would suit both in light and dark mode.

What about an automatic [deprecated] prefix in the description ?

I had also thought of this and it is actually a nice idea, but it has the disadvantage that you cannot simply customise this prefix.
See screenshots for the colours.

You would then have to add something like this (either to set the prefix or the message):

private array$optionDeprecationPrefix = [];publicfunctionsetOptionDeprecationPrefix(string$optionName,string$deprecationPrefix) {$this->optionDeprecationPrefix[$optionName] =$deprecationPrefix;}// On output:$deprecationPrefix =$this->optionDeprecationPrefix[$optionName] ??'deprecated';"[$deprecationPrefix]$optionDescription"

[...] grey [...]

Would be my personal choices, but colors are subjective, so let's see what others think about it ? :)

the disadvantage that you cannot simply customise this prefix.

That was not (in my mind) something configurable so i did not add the constraint.

But if you have commands from your app and bundles, that would be better to not allow a different style per command, no ?

I guess i'd do something like

sf listlorem:list            [deprecated] List all lorem from ipsumsf list -vlorem:list            [deprecated since 2.0] List all lorem from ipsumsf list -vvlorem:list            [deprecated since 2.0] List all lorem from ipsum  [Use foo:bar instead]

I like the grey too. We want this options to be less visible in the list, not highlight them.

And I don't see any reason for customizing the description prefix either. Consistency across commands is better.

I haven't checked the current state of the PR yet. But for sure, we cannot rely on color only:

• color blind people won't see them, causing accessibility issues
• not all terminals support colors

I have added@smnandre's suggestion for "[deprecated] prefix to the option description in the TextDescriptor.