Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[TwigBridge] Addemojify twig filter#54432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:7.1fromlyrixx:twig-emoji
Apr 5, 2024
Merged

Conversation

@lyrixx
Copy link
Member

@lyrixxlyrixx commentedMar 28, 2024•
edited
Loading

QA
Branch?7.1
Bug fix?no
New feature?yes
Deprecations?no
Issues
LicenseMIT

My most important PR of the year I guess 😅

image

welcoMattic, OskarStark, yceruto, makraz, alexander-schranz, and jeremyb reacted with thumbs up emojiwelcoMattic, lyrixx, faizanakram99, zmitic, and ilicmsreten reacted with laugh emojiadrienbrault, jeremyFreeAgent, and faizanakram99 reacted with hooray emojishakaran and jeremyb reacted with heart emoji
Copy link
Member

@stofstof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Shouldn't this have a change in TwigBundle to register the new extension when the symfony/emoji component is installed ?

derrabus and lyrixx reacted with thumbs up emoji
@smnandre
Copy link
Member

Do you plan to handle locale and emoji data ? How would the method change ? Should we implement all at once ?

@smnandre
Copy link
Member

emojify should be added in theUndefinedCallableHandler i think

--

Will you make the change in TwigBundle in a following PR or want to release both at same time ?

@lyrixx
Copy link
MemberAuthor

Do you plan to handle locale and emoji data ?

No need I guess...

@lyrixx
Copy link
MemberAuthor

Shouldn't this have a change in TwigBundle to register the new extension when the symfony/emoji component is installed ?

Done 👍🏼

smnandre reacted with thumbs up emoji

@lyrixx
Copy link
MemberAuthor

emojify should be added in theUndefinedCallableHandler i think

Good idea. 👍🏼 Thanks

smnandre reacted with thumbs up emoji

@lyrixx
Copy link
MemberAuthor

lyrixx commentedMar 29, 2024•
edited
Loading

Do you plan to handle locale and emoji data ? How would the method change ? Should we implement all at once ?

I now allows all catalog, and let the Emoji transliterator do all the checks.

smnandre reacted with heart emoji

@smnandre
Copy link
Member

Maybe a minor doubt about the name... as the slug filter is just "slug" and not "slugify" ... maybe "|emoji" ?

Nice "most important PR of the year" ;)

lyrixx reacted with thumbs up emojilyrixx and GromNaN reacted with laugh emoji

Copy link
Member

@ycerutoyceruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice, thanks!

(I left an optional request; feel free to ignore it if you think it's clear enough as it is)

@javiereguiluzjaviereguiluz added the ❄️ Feature FreezeImportant Pull Requests to finish before the next Symfony "feature freeze" labelApr 2, 2024
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I was fine with "emojify" personnaly, looks more like a verb than just "emoji" ("slug" is already a verb so "slugify" is not needed? does that work?)

lyrixx and yceruto reacted with thumbs up emoji
@lyrixx
Copy link
MemberAuthor

lyrixx commentedApr 5, 2024•
edited
Loading

Pr rebased, and updated

@lyrixxlyrixx changed the title[TwigBridge] Addemoji twig filter[TwigBridge] Addemojify twig filterApr 5, 2024
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The most important PR of 7.1! 😁

lyrixx, damienalexandre, andreybolonin, and yceruto reacted with heart emoji
@fabpot
Copy link
Member

Thank you@lyrixx.

@fabpotfabpot merged commitcd0dbb8 intosymfony:7.1Apr 5, 2024
@lyrixxlyrixx deleted the twig-emoji branchApril 5, 2024 13:14
fabpot added a commit that referenced this pull requestApr 10, 2024
This PR was merged into the 7.1 branch.Discussion----------[TwigBundle] re-allow Twig bridge 6.4 and 7.0| Q             | A| ------------- | ---| Branch?       | 7.1| Bug fix?      | no| New feature?  | no| Deprecations? | no| Issues        || License       | MITThe change was not necessary in#54432.Commits-------40d2155 re-allow Twig bridge 6.4 and 7.0
@fabpotfabpot mentioned this pull requestMay 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@stofstofstof requested changes

@derrabusderrabusderrabus left review comments

@fabpotfabpotfabpot approved these changes

@welcoMatticwelcoMatticwelcoMattic approved these changes

@ycerutoycerutoyceruto approved these changes

+2 more reviewers

@smnandresmnandresmnandre left review comments

@alamiraultalamiraultalamirault left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature❄️ Feature FreezeImportant Pull Requests to finish before the next Symfony "feature freeze"Status: ReviewedTwigBridge

Projects

None yet

Milestone

7.1

Development

Successfully merging this pull request may close these issues.

11 participants

@lyrixx@smnandre@fabpot@nicolas-grekas@stof@welcoMattic@derrabus@yceruto@alamirault@javiereguiluz@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp