Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[WebProfilerBundle] Update the search links in the profiler layout#54423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:7.1fromjaviereguiluz:profiler_search
Apr 5, 2024

Conversation

@javiereguiluz
Copy link
Member

QA
Branch?7.1
Bug fix?no
New feature?yes
Deprecations?no
Issues-
LicenseMIT

While working on#54421, I noticed that the page jump is mostly caused by the "profile search form" that we embed in the page via Ajax. This is how it looks expanded:

image

However, thew workflow is as follows:

  1. Click onSearch link
  2. The embedded search form expands
  3. Input the search criteria
  4. Click onSearch button
  5. You are redirected to the Search page to see the results

In this PR, I propose to NOT embed the search form in any pages and change the workflow as follows:

  1. Click onSearch link
  2. You are redirected to the Search page to see the results
  3. Input the search criteria (in the already expanded search form)
  4. Click onSearch button to see the results

This fixes some of the perceived performance slowdown and looks like a better workflow to me.


Also, the current sidebar shows these shortcut links:

image

  • "Last 10" shows the 10 most recent profiles
  • "Latest" shows the most recent profile available
  • "Search" expands the search form

This PR changes it to only show 2 shortcuts:

  • "Search profiles" shows the last 10 profiles and also the search form expanded
  • "Latest" shows the most recent profile aaailable

It looks like this:

search-links

@javiereguiluzjaviereguiluz added this to the7.1 milestoneMar 27, 2024
@javiereguiluzjaviereguiluz added the ❄️ Feature FreezeImportant Pull Requests to finish before the next Symfony "feature freeze" labelApr 2, 2024
@fabpot
Copy link
Member

Thank you@javiereguiluz.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Labels

Feature❄️ Feature FreezeImportant Pull Requests to finish before the next Symfony "feature freeze"Status: ReviewedWebProfilerBundle

Projects

None yet

Milestone

7.1

Development

Successfully merging this pull request may close these issues.

3 participants

@javiereguiluz@fabpot@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp