Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[WebProfilerBundle] Update the search links in the profiler layout#54423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
fabpot approved these changesApr 5, 2024
Member
fabpot commentedApr 5, 2024
Thank you@javiereguiluz. |
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
Feature❄️ Feature FreezeImportant Pull Requests to finish before the next Symfony "feature freeze" Status: ReviewedWebProfilerBundle
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on#54421, I noticed that the page jump is mostly caused by the "profile search form" that we embed in the page via Ajax. This is how it looks expanded:
However, thew workflow is as follows:
SearchlinkSearchbuttonIn this PR, I propose to NOT embed the search form in any pages and change the workflow as follows:
SearchlinkSearchbutton to see the resultsThis fixes some of the perceived performance slowdown and looks like a better workflow to me.
Also, the current sidebar shows these shortcut links:
This PR changes it to only show 2 shortcuts:
It looks like this: