Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Validator] Add arequireTld option toUrl constraint#54408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:7.1fromjaviereguiluz:finish_50871
Apr 5, 2024

Conversation

@javiereguiluz
Copy link
Member

QA
Branch?7.1
Bug fix?no
New feature?yes
Deprecations?no
Issues#50871
LicenseMIT

This implements the last part of#50871 following the suggestions from Wouter and Christian in
#50871 (comment)

@xabbuh
Copy link
Member

we need an entry in the Validator component's changelog file

@javiereguiluz
Copy link
MemberAuthor

I've added the changelog entry. Thanks!

@javiereguiluzjaviereguiluz added the ❄️ Feature FreezeImportant Pull Requests to finish before the next Symfony "feature freeze" labelApr 2, 2024
@OskarStarkOskarStark changed the title[Validator] Add a requireTld option to Url constraint[Validator] Add arequireTld option toUrl constraintApr 2, 2024
@fabpot
Copy link
Member

Thank you@javiereguiluz.

$this->protocols =$protocols ??$this->protocols;
$this->relativeProtocol =$relativeProtocol ??$this->relativeProtocol;
$this->normalizer =$normalizer ??$this->normalizer;
$this->requireTld =$requireTld ??$this->requireTld;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

In the issue, we discussed deprecating not setting this, so we can change the default totrue (which is in sync with theHostname constraint'srequireTld option).

Do we still want to do this?

If we don't, I would say we change the default of the parameter tofalse instead (I see no point making it nullable?)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@fabpotfabpot mentioned this pull requestMay 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@wouterjwouterjwouterj left review comments

@OskarStarkOskarStarkOskarStark left review comments

@xabbuhxabbuhxabbuh approved these changes

@fabpotfabpotfabpot approved these changes

+1 more reviewer

@smnandresmnandresmnandre left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature❄️ Feature FreezeImportant Pull Requests to finish before the next Symfony "feature freeze"Status: ReviewedValidator

Projects

None yet

Milestone

7.1

Development

Successfully merging this pull request may close these issues.

7 participants

@javiereguiluz@xabbuh@fabpot@wouterj@OskarStark@smnandre@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp