Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Make PasswordStrenghtValidator::estimateStrength public#54405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedMar 26, 2024
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
ro0NL left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
im wondering if the strenght value should be set as a violation parameter, so it can be obtained or used in translations using existing public API
derrabus commentedMar 26, 2024
Can you elaborate what kind of duplicate code you need to write currently because the method is not public? I'm not convinced yet, we need this change. Generally speaking, the method was not intended to be a public API which is why it's just a private method on the validator. If we wanted to make is reusable, we should rather extract it into a separate service that can be consumed in userland as well. Either way, we would need additional tests. Your change creates a new public API that is not covered by tests currently. |
xabbuh commentedApr 3, 2024
good idea, see#54479 |
Uh oh!
There was an error while loading.Please reload this page.
When implementing a password strength check in the frontend off an application duplicate code has to be made. By making the estimateStrength method public we can utilize the same logic/implementation as the backend validation.