Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle] [Command] Fix #54402: Suppress PHP warning when is_readable() tries to access dirs outside of open_basedir restrictions#54403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
xabbuh merged 1 commit intosymfony:5.4fromkopfsalat:fix_54402
Apr 3, 2024

Conversation

@kopfsalat
Copy link

QA
Branch?6.4
Bug fix?yes
New feature?no
Deprecations?no
IssuesFix#54402
LicenseMIT

Suppress PHP warning in CacheClearCommand when is_readable() tries to access dirs outside of open_basedir restrictions

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbotcarsonbot changed the title[FrameworkBundle][Command] Fix #54402: Suppress PHP warning when is_readable() tries to access dirs outside of open_basedir restrictions[FrameworkBundle] [Command] Fix #54402: Suppress PHP warning when is_readable() tries to access dirs outside of open_basedir restrictionsMar 26, 2024
@xabbuh
Copy link
Member

For 5.4, right?

@kopfsalat
Copy link
Author

kopfsalat commentedMar 27, 2024•
edited
Loading

For 5.4, right?

Hi, we're working with 6.4 and I found the bug there, so I worked on the 6.4 branch for this fix. But I just looked into the 5.4 branch and the patch should apply there, too. The line is the same.

xabbuh reacted with thumbs up emoji

@xabbuhxabbuh modified the milestones:6.4,5.4Mar 27, 2024
…eadable() tries to access dirs outside of open_basedir restrictions
@xabbuh
Copy link
Member

Thank you@kopfsalat.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@xabbuhxabbuhxabbuh approved these changes

@lyrixxlyrixxAwaiting requested review from lyrixx

@ycerutoycerutoAwaiting requested review from yceruto

@chalasrchalasrAwaiting requested review from chalasr

@dunglasdunglasAwaiting requested review from dunglas

@OskarStarkOskarStarkAwaiting requested review from OskarStark

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

3 participants

@kopfsalat@carsonbot@xabbuh
[8]ページ先頭
©2009-2025 Movatter.jp