Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Messenger] Make Doctrine connection ignore unrelated tables on setup#54392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.4fromMatTheCat:ticket_49108
Apr 8, 2024

Conversation

@MatTheCat
Copy link
Contributor

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
IssuesFix#49108
LicenseMIT

Introspecting the whole database can cause issues like Doctrine crashing on unknown column types. This PR updates the schema assets filter (added by#31625) to only consider the messages table, as it is the only one a connection setup needs to care about.

Copy link
Member

@GromNaNGromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. Thanks for the test.

@fabpot
Copy link
Member

Thank you@MatTheCat.

@fabpotfabpot merged commit950ca75 intosymfony:5.4Apr 8, 2024
@MatTheCatMatTheCat deleted the ticket_49108 branchApril 8, 2024 12:45
This was referencedApr 29, 2024
@chriskapp
Copy link
Contributor

In our case this PR breaks on postgres if a newer version of doctrine dbal is used since the filter receives alsoAbstractAsset objects s.
image

This issue is also already fixed by@xabbuh s.
symfony/doctrine-messenger@v6.4.7...6.4

So for others searching this issue, we only need to wait for the next v6.4.8 release.

xabbuh, J-roen, and thePanz reacted with thumbs up emoji

@thePanz
Copy link
Contributor

For reference:#54775

ppritel-satoshilabs reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@GromNaNGromNaNGromNaN approved these changes

@derrabusderrabusderrabus approved these changes

@xabbuhxabbuhxabbuh approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

8 participants

@MatTheCat@fabpot@chriskapp@thePanz@GromNaN@derrabus@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp