Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Notifier] LOX24 SMS bridge#54356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:7.1fromalebedev80:7.1
Apr 14, 2024
Merged

[Notifier] LOX24 SMS bridge#54356

fabpot merged 1 commit intosymfony:7.1fromalebedev80:7.1
Apr 14, 2024

Conversation

@alebedev80
Copy link
Contributor

@alebedev80alebedev80 commentedMar 20, 2024•
edited by xabbuh
Loading

QA
Branch?7.1
Bug fix?no
New feature?yes
Deprecations?no
LicenseMIT
Doc PRsymfony/symfony-docs#19692
Recipe PRsymfony/recipes#1300

Add LOX24 SMS Gateway bridge to Symfony Notifier.
A Germany based SMS Gateway.

@carsonbotcarsonbot added this to the7.1 milestoneMar 20, 2024
@alebedev80alebedev80 changed the base branch from7.1 to6.4March 20, 2024 17:56
@xabbuhxabbuh changed the base branch from6.4 to7.1March 20, 2024 20:29
@symfonysymfony deleted a comment fromcarsonbotMar 21, 2024
Copy link
Contributor

@OskarStarkOskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please add your class to the framework config and to the Notifier: UnsupportedSchemeException/UnsupportedSchemeExceptionTest classes, thanks

@alebedev80
Copy link
ContributorAuthor

alebedev80 commentedMar 21, 2024•
edited
Loading

@OskarStark what's data should be by indexes 0 and 1? method\Symfony\Component\Notifier\Test\TransportFactoryTestCase::createProvider()

    /**     * @return iterable<array{0: string, 1: string, 2: TransportInterface}>     */    abstract public static function createProvider(): iterable;

@OskarStark
Copy link
Contributor

OskarStark commentedMar 21, 2024•
edited
Loading

Please have a look at other bridges tests

@carsonbotcarsonbot changed the titleLOX24 SMS Gateway Notifier[Notifier] LOX24 SMS Gateway NotifierMar 21, 2024
@OskarStarkOskarStark changed the title[Notifier] LOX24 SMS Gateway Notifier[Notifier] LOX24 SMS bridgeMar 21, 2024
@alebedev80
Copy link
ContributorAuthor

@OskarStark i think i fixed everything which you mentioned. I'm sorry if missed something...
Please review code again.

@alebedev80
Copy link
ContributorAuthor

@OskarStark please check again

@alebedev80
Copy link
ContributorAuthor

@OskarStark fixed.
Please check again

Copy link
Contributor

@OskarStarkOskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good to go from my side

@OskarStark
Copy link
Contributor

Tests are failing

@alebedev80
Copy link
ContributorAuthor

Tests are failing

Fixed

@fabpot
Copy link
Member

Thank you@alebedev80.

OskarStark reacted with thumbs up emoji

@fabpotfabpot merged commitcfd9ad0 intosymfony:7.1Apr 14, 2024
@alebedev80
Copy link
ContributorAuthor

Thank you all!

OskarStark reacted with thumbs up emoji

@fabpotfabpot mentioned this pull requestMay 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@OskarStarkOskarStarkOskarStark approved these changes

@fabpotfabpotfabpot approved these changes

@lyrixxlyrixxAwaiting requested review from lyrixx

@dunglasdunglasAwaiting requested review from dunglas

@ycerutoycerutoAwaiting requested review from yceruto

@kbondkbondAwaiting requested review from kbond

@chalasrchalasrAwaiting requested review from chalasr

@jderussejderusseAwaiting requested review from jderusse

@xabbuhxabbuhAwaiting requested review from xabbuh

@welcoMatticwelcoMatticAwaiting requested review from welcoMattic

@stofstofAwaiting requested review from stof

@smnandresmnandreAwaiting requested review from smnandre

Assignees

No one assigned

Projects

None yet

Milestone

7.1

Development

Successfully merging this pull request may close these issues.

7 participants

@alebedev80@OskarStark@fabpot@stof@welcoMattic@smnandre@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp