Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Messenger] Swallow Exception on Rollback#54355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:7.4
Are you sure you want to change the base?
Changes fromall commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
@@ -34,7 +34,10 @@ protected function handleForManager(EntityManagerInterface $entityManager, Envel | ||||||||
return $envelope; | ||||||||
} catch (\Throwable $exception) { | ||||||||
try { | ||||||||
$entityManager->getConnection()->rollBack(); | ||||||||
} catch (\Throwable $e) { | ||||||||
ContributorAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Suggested change
Is it better to pass along some notification of rollback failure? This will interfere with the check a few lines below though, so would need to be structured differently. | ||||||||
} | ||||||||
if ($exception instanceof HandlerFailedException) { | ||||||||
// Remove all HandledStamp from the envelope so the retry will execute all handlers again. | ||||||||