Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Messenger] [Amqp] Add default exchange support#54275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:7.3fromilyachase:fix_45784
Mar 28, 2025

Conversation

ilyachase
Copy link
Contributor

@ilyachaseilyachase commentedMar 13, 2024•
edited by OskarStark
Loading

QA
Branch?7.2
Bug fix?no
New feature?yes
Deprecations?no
IssuesFix#45784
LicenseMIT

Usage:

transports:my_queue:dsn:'%env(MESSENGER_TRANSPORT_DSN)%'options:exchange:# Indicates that the default Exchange is to be usedname:''default_publish_routing_key:my_queuequeues:my_queue:~

It is not a breaking change, because currently usingname: '' leads to theCould not declare exchange. Exchanges must have a name error. This PR allows using the default exchange instead.

It's also possible to add more queues and then use them directly with a stamp:

          queues:            foo: ~            bar: ~
$messageBus->dispatch(new MyMessage(), [new AmqpStamp('bar')]);

@carsonbotcarsonbot added this to the7.1 milestoneMar 13, 2024
@carsonbotcarsonbot changed the title[Messenger][Amqp] Added default exchange support[Messenger] [Amqp] Added default exchange supportMar 13, 2024
@ilyachaseilyachase changed the title[Messenger] [Amqp] Added default exchange support[Messenger] [Amqp] Add default exchange supportMar 13, 2024
@ilya-levin-lokalise

@fabian@nicolas-grekas@stof Hey folks, sorry for pinging you directly, but you are the people who helped move forward my previous PR. Could this one also get some attention - it had none for longer than a month? 🙏

@xabbuhxabbuh modified the milestones:7.1,7.2May 10, 2024
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM (although I don't have any knowledge about the default exhange, so I'd trust you on this aspect).

Please just mention this new case in the descriptions of the options (L138)

ilyachase reacted with rocket emoji
@ilyachase
Copy link
ContributorAuthor

@fabpot@stof Hey folks, can I have one more review here, please? 🙂

@ilyachase
Copy link
ContributorAuthor

@nicolas-grekas hello, how can we move forward with this PR? 🙏

@ilyachase
Copy link
ContributorAuthor

Hi@OskarStark do you think we can get this one gong? 🙂

@ilyachase
Copy link
ContributorAuthor

@fabpot@stof Hey folks, can I have one more review here, please? 🙂

@fabpotfabpot modified the milestones:7.2,7.3Nov 20, 2024
Copy link
Member

@wouterjwouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Would love to see this one in 7.3, we're using the default exchange for most of our queues now and having to disable auto_setup is not ideal.

@ilyachase
Copy link
ContributorAuthor

@wouterj Thanks for creating traction. I just rebased my branch to the freshest 7.3 branch.

@OskarStarkOskarStark changed the title[Messenger] [Amqp] Add default exchange support[Messenger][Amqp] Add default exchange supportMar 10, 2025
@wouterjwouterj added the ❄️ Feature FreezeImportant Pull Requests to finish before the next Symfony "feature freeze" labelMar 27, 2025
@carsonbotcarsonbot changed the title[Messenger][Amqp] Add default exchange support[Messenger] [Amqp] Add default exchange supportMar 27, 2025
@fabpot
Copy link
Member

Thank you@ilyachase.

ilyachase and marvinhinz reacted with heart emoji

@fabpotfabpot merged commit23e2230 intosymfony:7.3Mar 28, 2025
7 of 8 checks passed
@fabpotfabpot mentioned this pull requestMay 2, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@wouterjwouterjwouterj approved these changes

@OskarStarkOskarStarkAwaiting requested review from OskarStark

Assignees
No one assigned
Labels
FeatureMessenger❄️ Feature FreezeImportant Pull Requests to finish before the next Symfony "feature freeze"Status: Reviewed
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.

[AmqpMessenger] Allow using the default amqp exchange
8 participants
@ilyachase@ilya-levin-lokalise@fabpot@nicolas-grekas@wouterj@OskarStark@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp