Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpKernel] Improve error reporting when requiring the wrong Request class#54107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:7.1fromilyachase:fix_54015
Mar 9, 2024

Conversation

@ilyachase
Copy link
Contributor

@ilyachaseilyachase commentedFeb 29, 2024•
edited by nicolas-grekas
Loading

QA
Branch?7.1
Bug fix?no
New feature?yes
Deprecations?no
IssuesFix#54015
LicenseMIT

NearMissValueResolverException is introduced to be used inside any implementer ofValueResolverInterface to specify why exactly a value cannot be resolved. It's later used inArgumentResolver to compute an exception if no value resolvers can resolve the value.

@ilyachase
Copy link
ContributorAuthor

Not sure what to do with failed checks - errors seem irrelevant to my changes. Please help.

@carsonbotcarsonbot changed the titleFix 54015[HttpKernel] Fix 54015Feb 29, 2024
@derrabus
Copy link
Member

Please find a meaningful title for your PR. We use PR titles to compose the change log.

Not sure what to do with failed checks

If you didn't cause them, ignore them.

@ilyachaseilyachase changed the title[HttpKernel] Fix 54015[HttpKernel] Improve error reporting when requiring the wrong Request classFeb 29, 2024
@ilyachase
Copy link
ContributorAuthor

Please find a meaningful title for your PR. We use PR titles to compose the change log.

Done.

If you didn't cause them, ignore them.

👌

@ilyachaseilyachase requested a review fromstofFebruary 29, 2024 14:12
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I like that :)

ilyachase and asrorbekh reacted with hooray emoji
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Almost GTM :)

@ilyachase
Copy link
ContributorAuthor

@stof@nicolas-grekas hey folks, let's get this PR moving? 🙂 I believe I addressed everything

@fabpot
Copy link
Member

Thank you@ilyachase.

ilyachase and asrorbekh reacted with heart emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@stofstofAwaiting requested review from stof

@jprivet-devjprivet-devAwaiting requested review from jprivet-dev

+2 more reviewers

@ilya-levin-lokaliseilya-levin-lokaliseilya-levin-lokalise left review comments

@stloydstloydstloyd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

7.1

Development

Successfully merging this pull request may close these issues.

Improve error reporting when targetting the wrong Request class

9 participants

@ilyachase@derrabus@fabpot@stloyd@nicolas-grekas@stof@jprivet-dev@ilya-levin-lokalise@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp