re:#535 (comment)

@vicb: i am sure there could be some use cases, maybe we should just disable interface injection entirely if a manual call has been set?

I don't think we have any basis to determine whether a user wants a method to be called multiple times or only once. If this is an issue we should remove any interface injectors from the core.

@kriswallsmith: well similar issues can happen with any 3rd party bundle that uses interface injection. so i think the approach of just disabling interface injection if a single manual method call is set, should work best here: aka setting a manual method calls means you want to manually manage setter injection. should make things clear in the docs too.

Symfony is built around the user being explicit about his intention and us not making any assumptions. This patch bakes in an assumption that the user only wants a method to be called once and creates an unnecessary limitation.

I have reverted this patch for now as I think@kriswallsmith and@schmittjoh have good arguments.

I agree. Interfaces and parent definitions are “upstream” and should be prepended.
On Wednesday, April 13, 2011 at 5:38 AM, schmittjoh wrote:

As stated on the other PR, I think prepending the interface injection calls instead of appending them is the best option. I also choose that when you inherit from another definition that has method calls, and IIRC this is also what Spring does in these cases.

Thoughts?

Reply to this email directly or view it on GitHub:
#541 (comment)

Well then you still have redundant method calls, which may or may not lead to simply adding overhead or actually causing issues if the second method call doesnt simply override the previous one.

So I still think the best solution is to simply disable interface injection for any definition that defines an explicit method call.

I have opened a pull that implements what I suggested:#544

closing this pull ..
(btw: i think this pull was also additionally flawed because it would probably break if one would use multiple interfaces which are configured to trigger injections)