Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Messenger] Passing actualEnvelope toWorkerMessageRetriedEvent#54057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:5.4fromdaffoxdev:fix_52914
Jul 5, 2024

Conversation

@daffoxdev
Copy link
Contributor

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
IssuesFix#52914
LicenseMIT

InSendFailedMessageForRetryListener fixed theEnvelope instance that passes toWorkerMessageRetriedEvent. Now it is instance ofEnvelope the that is returned by transport sender and could include such stamps asTransportMessageIdStamp. Previously to the event passed the not actual envelope that is created before passed tosend()

  • changes in SendFailedMessageForRetryListener
  • added new test for this case inSendFailedMessageForRetryListenerTest

valtzu reacted with thumbs up emoji
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM with some comments, thanks.

daffoxdev reacted with thumbs up emoji
…al stamps after sentSigned-off-by: j.apsitis <yury.apsitis.dev@gmail.com>
@fabpot
Copy link
Member

Thank you@daffoxdev.

@fabpotfabpot merged commit2ad804f intosymfony:5.4Jul 5, 2024
This was referencedJul 26, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@xabbuhxabbuhxabbuh approved these changes

@nicolas-grekasnicolas-grekasAwaiting requested review from nicolas-grekas

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

5 participants

@daffoxdev@carsonbot@fabpot@nicolas-grekas@xabbuh
[8]ページ先頭
©2009-2025 Movatter.jp