Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[VarExporter] Bugfix/workaround jit issue#54054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@verfriemelt-dot-org
Copy link
Contributor

QA
Branch?6.4
Bug fix?yes
New feature?no
Deprecations?no
IssuesFixes/Workaround for#54053
LicenseMIT

I managed to fix the erratically behavior with this patch, but i have no idea how one would test this.
It seems tracing jit has some issues with the ternary operator.

Let me know what you think, i have no idea how to work with that properly :)

@nicolas-grekas
Copy link
Member

Thanks for this! Did you report the issue to php-src? It should be fixed there ideally, and VarExporter could be showcased as the reproducer for them.

@nicolas-grekas
Copy link
Member

I'm now seeingphp/php-src#13508 so I have my answer :)

verfriemelt-dot-org reacted with thumbs up emoji

@verfriemelt-dot-org
Copy link
ContributorAuthor

i did :)
maybe i am to tired after figuring all this out, but i really do not understand how i broke the test in the pipeline here? 🤔

@carsonbotcarsonbot changed the titleBugfix/workaround var-exporter jit issue #54053[VarExporter] Bugfix/workaround var-exporter jit issue #54053Feb 26, 2024
@nicolas-grekasnicolas-grekas changed the title[VarExporter] Bugfix/workaround var-exporter jit issue #54053[VarExporter] Bugfix/workaround jit issueFeb 26, 2024
@nicolas-grekasnicolas-grekasforce-pushed thebugfix-var-exporter-jit-issue-54053 branch from96008d6 tob9a9d35CompareFebruary 26, 2024 08:37
@nicolas-grekasnicolas-grekas merged commit2e4de58 intosymfony:6.4Feb 26, 2024
@nicolas-grekas
Copy link
Member

Thank you@verfriemelt-dot-org

jschaedl reacted with hooray emojiverfriemelt-dot-org reacted with heart emoji

@k0d3r1s
Copy link
Contributor

@nicolas-grekas any ETA on next 6.4 minor release with this fix?

@nicolas-grekas
Copy link
Member

nicolas-grekas commentedFeb 26, 2024•
edited
Loading

We do releases at the end of each months (and we're at the end of one, so shouldn't be long.)

This was referencedFeb 27, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

4 participants

@verfriemelt-dot-org@nicolas-grekas@k0d3r1s@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp