Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Translation] Fix extracting qualifiedt() function calls#54010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:6.4fromrvanvelzen:fix/trans-extract-t
Feb 21, 2024

Conversation

@rvanvelzen
Copy link
Contributor

QA
Branch?6.4
Bug fix?yes
New feature?no
Deprecations?no
IssuesFix#53835
LicenseMIT

t() calls are generally qualified. The visitor used to look at the full name for the function call, but since#53624 this is replaced by the qualified name.

This PR adjusts the comparison to only look at the last part of the qualified name.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@nicolas-grekas
Copy link
Member

/cc@VincentLanglet could you please have a look?

VincentLanglet reacted with thumbs up emoji

@fabpot
Copy link
Member

Thank you@rvanvelzen.

@fabpotfabpot merged commitfce2d88 intosymfony:6.4Feb 21, 2024
@rvanvelzenrvanvelzen deleted the fix/trans-extract-t branchFebruary 21, 2024 12:26
This was referencedFeb 27, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@welcoMatticwelcoMatticAwaiting requested review from welcoMatticwelcoMattic is a code owner

+1 more reviewer

@VincentLangletVincentLangletVincentLanglet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

5 participants

@rvanvelzen@carsonbot@nicolas-grekas@fabpot@VincentLanglet
[8]ページ先頭
©2009-2025 Movatter.jp