Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[WebProfilerBundle] Allow to search inside profiler tables#53885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:7.1fromjaviereguiluz:profiler_tables
Mar 17, 2024

Conversation

@javiereguiluz
Copy link
Member

QA
Branch?7.1
Bug fix?no
New feature?yes
Deprecations?no
Issues-
LicenseMIT

In the profiler, sometimes tables are very long and it's hard to find things in all those rows. This PR injects a<input type="search"> field in all tables to have a real-time filter on table contents:

image

In action it looks like this:

profiler-table-filter

alamirault reacted with thumbs up emojiHeahDude reacted with rocket emoji
@javiereguiluz
Copy link
MemberAuthor

I did all the changes that you suggested, except a couple of them (and I added a comment in those). Thanks for the nice review!

smnandre reacted with thumbs up emoji

@javiereguiluzjaviereguiluz added Ready and removed Ready labelsMar 5, 2024
@javiereguiluz
Copy link
MemberAuthor

If you want me to do any other change here, please tell me.

Otherwise, please review and approve this PR so maintainers can see it as ready. Thanks!

@fabpot
Copy link
Member

Thank you@javiereguiluz.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof left review comments

+2 more reviewers

@smnandresmnandresmnandre left review comments

@AurelienPillevesseAurelienPillevesseAurelienPillevesse approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

7.1

Development

Successfully merging this pull request may close these issues.

6 participants

@javiereguiluz@fabpot@stof@smnandre@AurelienPillevesse@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp