Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Workflow] determines places from transitions#53866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:7.1fromlyrixx:workflow-auto-places
Feb 11, 2024

Conversation

@lyrixx
Copy link
Member

QA
Branch?7.1
Bug fix?no
New feature?yes
Deprecations?no
IssuesFix#52378
LicenseMIT

TomasVotruba reacted with thumbs up emoji
@carsonbotcarsonbot added this to the7.1 milestoneFeb 8, 2024
@carsonbotcarsonbot changed the title[workflow] determines places form transitions[Workflow] determines places form transitionsFeb 8, 2024
@nicolas-grekasnicolas-grekas changed the title[Workflow] determines places form transitions[Workflow] determines places from transitionsFeb 9, 2024
@nicolas-grekas
Copy link
Member

What about throwing if at least one place is defined?
The behavior would be:

  • if you don't define any place => auto-guessed from transitions
  • if you define at least one place => require them all to be listed (allowing some sort of strict mode definitions to be typo-safe)

@lyrixx
Copy link
MemberAuthor

lyrixx commentedFeb 9, 2024
edited
Loading

The issues comes from the framework bundle. I want people to be able to

  • not define dumb places
  • define places with some metadata
framework:workflows:blog_publishing:metadata:title:'Blog Publishing Workflow'places:draft:metadata:max_num_of_words:500transitions:to_review:from:draftto:review

@lyrixx
Copy link
MemberAuthor

(fixed fabbot, phpunit failures seems not related)

@fabpot
Copy link
Member

Thank you@lyrixx.

@fabpotfabpot merged commit0c362d2 intosymfony:7.1Feb 11, 2024
@lyrixxlyrixx deleted the workflow-auto-places branchFebruary 12, 2024 09:23
@fabpotfabpot mentioned this pull requestMay 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

7.1

Development

Successfully merging this pull request may close these issues.

[Workflow][RFC] Simplify workflow configuration

4 participants

@lyrixx@nicolas-grekas@fabpot@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp