Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Mailer][Postmark][Webhook] Accept different date formats#53829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

aleho
Copy link
Contributor

QA
Branch?6.4
Bug fix?yes
New feature?no
Deprecations?no
IssuesFix#53788
LicenseMIT

Postmark webhooks sometimes use "plain" ISO 6801 format, sometimes including 7 digits microseconds.
We're currently seeing2024-02-07T09:41:16.7048881Z for example.

As the PHP parameter only allows for 6 digits neither would parse without fallbacks.

@carsonbotcarsonbot added this to the6.4 milestoneFeb 7, 2024
@carsonbotcarsonbot changed the title[Mailer][Postmark][Webhook] Accept different date formats[Mailer][Webhook] [Postmark] Accept different date formatsFeb 7, 2024
@alehoaleho changed the title[Mailer][Webhook] [Postmark] Accept different date formats[Mailer][Postmark][Webhook] Accept different date formatsFeb 7, 2024
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for digging this.
Can you please as some test cases to cover this?

Postmark webhooks sometimes use "plain" ISO 6801 format, sometimesincluding 7 digits microseconds. As the PHP parameter only allows for 6digits neither would parse without fallbacks.Fixessymfony#53788
@alehoalehoforce-pushed thefix-postmark-webhook-dates branch fromaa9e308 to8af3d02CompareFebruary 8, 2024 17:33
@aleho
Copy link
ContributorAuthor

@nicolas-grekas I replaced all the custom formats in the tests with PHP's "official" ISO 8601 format. I guess it's supposed to be compatible with the standard and if not, Postmark is sending broken webhooks anyway. Is that OK?

@nicolas-grekas
Copy link
Member

Thank you@aleho.

aleho reacted with laugh emoji

@nicolas-grekasnicolas-grekas merged commitadbe494 intosymfony:6.4Feb 9, 2024
@alehoaleho deleted the fix-postmark-webhook-dates branchFebruary 9, 2024 09:40
This was referencedFeb 27, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

Assignees
No one assigned
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

3 participants
@aleho@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp