NotificationsYou must be signed in to change notification settings
Fork9.6k
Star30.4k

[DomCrawler][Form] Fix the exclusion of <template>#53826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:6.4frommpiot:dom-crawler-form-turbo-stream

Feb 9, 2024

Merged

[DomCrawler][Form] Fix the exclusion of <template>#53826

nicolas-grekas merged 1 commit intosymfony:6.4frommpiot:dom-crawler-form-turbo-stream

Feb 9, 2024

Conversation

Copy link

Contributor

mpiot commentedFeb 7, 2024•
edited
Loading

Q	A
Branch?	6.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Issues	Fix#53823
License	MIT

In the DomCrawler, the way to get fields via xPath avoid to find elements inside a<template> element:

<form><template><inputtype="text"name="not_selected_because_in_template"/></template><inputtype="text"name="selected_because_out_of_template"/></form>

But, it appear it also exclude form elements if the<form> is in a<template> (eg: in a<turbo-stream>), that bug-fix keep the previous behavior but allow the following:

<turbo-stream><template><form><inputtype="text"name="selected_because_in_turbo_stream_1"/><inputtype="text"name="selected_because_in_turbo_stream_2"/></form></template></turbo-stream>

As mentioned in#53823, an alternative should be to use[not(ancestor::template/ancestor::form)] in the xPath to allow:

<template><form><inputtype="text"name="selected_because_parent_is_form_1"/><inputtype="text"name="selected_because_parent_is_form_2"/></form></template>