Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

• Always add tests
• Keep backward compatibility (seehttps://symfony.com/bc).
• Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
• Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

The class prefix should beSmsense to avoid having a package nameds-m-ense-notifier

Made the changes

@jimiero Can you have a look at the tests, some are broken for this new notifier.

@jimiero Can you have a look at the tests, some are broken for this new notifier.

Changed them and now the tests are not failing anymore.

@jimiero Tests are still broken apparently, seehttps://github.com/symfony/symfony/actions/runs/7955729597/job/21715188628?pr=53734#step:8:126

@jimiero Tests are still broken apparently, seehttps://github.com/symfony/symfony/actions/runs/7955729597/job/21715188628?pr=53734#step:8:126

Works just fine if I do this instead

`$response = $this->createMock(ResponseInterface::class);
$response->method('getStatusCode')->willReturn(200);
$response->method('getContent')->willReturn(file_get_contents(DIR.'/Fixtures/success-response.json'));
$client = new MockHttpClient($response);
$transport = $this->createTransport($client);
$sentMessage = $transport->send(new SmsMessage('+40701111111', 'Hello!'));

    $this->assertInstanceOf(SentMessage::class, $sentMessage);    $this->assertSame('63444830-5857-50da-d5f6-69f3719aa916', $sentMessage->getMessageId());`

if I do:

$response = new JsonMockResponse(file_get_contents(__DIR__.'/Fixtures/success-response.json'));

it fails seems, any suggestions?

My bad with suggestion to use that version of mock, you put encoded body into json mock which expects to get php array instead.

Either you can remove the fixture file and inject the php array into json mock or use again interface mock again.

My bad with suggestion to use that version of mock, you put encoded body into json mock which expects to get php array instead.

Either you can remove the fixture file and inject the php array into json mock or use again interface mock again.

Yep that was it, pushed changes by removing fixtures file and replaced JsonMockResponse input with a php array instead.

Thank you@jimiero.