NotificationsYou must be signed in to change notification settings
Fork9.6k
Star30.4k

[HttpFoundation] Prevent duplicated headers when using Early Hints#53733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:6.4fromdunglas:fix/duplicate-headers-when-103

Feb 8, 2024

Merged

[HttpFoundation] Prevent duplicated headers when using Early Hints#53733

nicolas-grekas merged 1 commit intosymfony:6.4fromdunglas:fix/duplicate-headers-when-103

Feb 8, 2024

Conversation

Copy link

Member

dunglas commentedFeb 2, 2024

Q	A
Branch?	6.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Issues	n/a
License	MIT

Currently, headers are being duplicated in the final response if a 103 response has previously been sent. This patch fixes the issue.

Before:

< HTTP/2 103< alt-svc: h3=":443"; ma=2592000< cache-control: no-cache, private< date: Fri, 02 Feb 2024 15:21:00 GMT< link: </style.css>; rel=preload; as=style< server: Caddy< x-powered-by: PHP/8.3.1< HTTP/2 200< cache-control: no-cache, private< cache-control: no-cache, private< content-type: text/html; charset=UTF-8< date: Fri, 02 Feb 2024 15:21:00 GMT< date: Fri, 02 Feb 2024 15:21:00 GMT< link: </style.css>; rel=preload; as=style< link: </style.css>; rel=preload; as=style

carsonbot added Status: Needs Review Bug HttpFoundation labels

Feb 2, 2024

carsonbot added this to the6.4 milestone

Feb 2, 2024

Copy link

Member

nicolas-grekas commentedFeb 5, 2024

Can this be covered by a test case?

Copy link

MemberAuthor

@nicolas-grekas the only way I can think of to test this is to add FrankenPHP to the CI to do an integration test, or to override the built-inheader() function. What would be your preferred approach?