Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[String] Fix plural of word ending by pus#53715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

Fan2Shrek
Copy link
Contributor

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
IssuesFix#53685
LicenseMIT

Fix the pluralization of words ending by 'pus' like campus.
Previously was campi instead of campuses

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Fan2Shrek reacted with thumbs up emoji

@carsonbotcarsonbot changed the titleFix plurial of word ending by pus[String] Fix plurial of word ending by pusFeb 1, 2024
@Fan2ShrekFan2Shrekforce-pushed thefix/words-ending-by-pus-plurial branch from2070cd4 to963318fCompareFebruary 1, 2024 08:10
@javiereguiluzjaviereguiluz changed the title[String] Fix plurial of word ending by pus[String] Fix plural of word ending by pusFeb 1, 2024
@nicolas-grekas
Copy link
Member

Thank you@Fan2Shrek.

Fan2Shrek reacted with thumbs up emoji

@nicolas-grekasnicolas-grekas merged commit4e6d1b0 intosymfony:5.4Feb 1, 2024
['supmacoppih', 11, false, false, 'hippocampi'],

// campuses (campus)
['sup', 3, true, true, 'puses'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

What about other words ending inpus besidescampus andhippocampus ? If we don't have a generic rule, maybe we should actually return the 2 options for thepus ending.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

After some research its seems that onlyhippocampus is irregular
Words likeopus oroctopus are plurialized withpuses

I'm a non-native english speaker if someone can confirm 👀

This was referencedFeb 27, 2024
@fabpotfabpot mentioned this pull requestFeb 27, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@lyrixxlyrixxlyrixx left review comments

@stofstofstof left review comments

@javiereguiluzjaviereguiluzjaviereguiluz approved these changes

@derrabusderrabusderrabus approved these changes

@maxbeckersmaxbeckersmaxbeckers approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

8 participants
@Fan2Shrek@carsonbot@nicolas-grekas@javiereguiluz@lyrixx@stof@derrabus@maxbeckers
[8]ページ先頭
©2009-2025 Movatter.jp