In DoctrineMongoDBBundle v5, we removed.class attributes to plain class names in service definitions (seedoctrine/DoctrineMongoDBBundle#821). The class fordoctrine_mongodb.odm.default_xml_metadata_driver changed fromdoctrine_mongodb.odm.metadata.xml.class toDoctrine\Bundle\MongoDBBundle\Mapping\Driver\XmlDriver.

I fixed the detection of the driver by checking the uppercaseXml andYaml because it might be necessary if the same change is made to DoctrineBundle.

doctrine/mongodb-odm-bundle requiressymfony/doctrine-bridge: "^6.4 || ^7.0" so this patch if not required for older versions of Symfony even if it could be applied.

GromNaN added the DoctrineBridge label

Jan 30, 2024

GromNaN added this to the6.4 milestone

Jan 30, 2024

GromNaN requested a review fromderrabus

January 30, 2024 10:49

carsonbot added the Status: Needs Review label

Jan 30, 2024

carsonbot changed the title~~[DoctrineBridge] Fix detection of Xml/Yaml driver in DoctrineExtension~~[DoctrineBridge] Fix detection of Xml/Yaml driver in DoctrineExtension

Jan 30, 2024

carsonbot added the Bug label

Jan 30, 2024

carsonbot modified the milestones:6.4,5.4

Jan 30, 2024

This comment was marked as resolved.

GromNaN mentioned this pull request

Jan 30, 2024

Configuration with non bundled mapping and xml mapping is broken in 5.0doctrine/DoctrineMongoDBBundle#841

Closed

GromNaN changed the base branch from5.4 to6.4

January 30, 2024 10:52

GromNaN force-pushed thedoctrine-xml-detect branch frome040afe tobaf1919Compare

January 30, 2024 10:52

Copy link

frenchcomp commentedJan 30, 2024

Thanks@GromNaN !

nicolas-grekas modified the milestones:5.4,6.4

Jan 30, 2024

nicolas-grekas approved these changes

Jan 30, 2024

View reviewed changes

Copy link

Member

nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

That's for 5.4, no?

src/Symfony/Bridge/Doctrine/DependencyInjection/AbstractDoctrineExtension.php OutdatedShow resolvedHide resolved

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Jan 30, 2024

Copy link

MemberAuthor

GromNaN commentedJan 30, 2024

That's for 5.4, no?

That's not necessary fordoctrine/mongodb-odm-bundle since the bug is in a version that requires 6.4+.

[DoctrineBridge] Fix detection of Xml/Yaml driver in DoctrineExtension

662b8f2

nicolas-grekas force-pushed thedoctrine-xml-detect branch from37b2bb3 to662b8f2Compare

January 30, 2024 11:24

Copy link

Member

nicolas-grekas commentedJan 30, 2024

Thank you@GromNaN.

nicolas-grekas merged commitcb0817c intosymfony:6.4

Jan 30, 2024

GromNaN deleted the doctrine-xml-detect branch

January 30, 2024 11:27

This was referencedJan 31, 2024

Release v6.4.3#53691

Merged

Release v7.0.3#53692

Merged

MatTheCat mentioned this pull request

Nov 5, 2024

Fix wiring of PHP metadata drivers on doctrine/orm 3.xdoctrine/DoctrineBundle#1832

Merged

MatTheCat added a commit to MatTheCat/symfony that referenced this pull request

Nov 5, 2024

[DoctrineBridge] Backportsymfony#53681

f7b61a2

MatTheCat mentioned this pull request

Nov 5, 2024

[DoctrineBridge] Backport detection fix of Xml/Yaml driver in DoctrineExtension#58772

Merged

nicolas-grekas added a commit that referenced this pull request

Nov 6, 2024

bug#58772[DoctrineBridge] Backport detection fix of Xml/Yaml driver…

e1da961

… in DoctrineExtension (MatTheCat)This PR was merged into the 5.4 branch.Discussion----------[DoctrineBridge] Backport detection fix of Xml/Yaml driver in DoctrineExtension| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Issues        |Fixdoctrine/DoctrineBundle#1832| License       | MIT#53681 got merged on 6.4, but the DoctrinBundle still needs it on 5.4 😅Commits-------f7b61a2 [DoctrineBridge] Backport#53681

nicolas-grekas added a commit that referenced this pull request

Nov 6, 2024

Merge branch '5.4' into 6.4

44c2a8b