Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Cache][Lock][Semaphore] Optimize factories#53598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
HypeMC wants to merge1 commit intosymfony:7.1fromHypeMC:optimize-storefactory

Conversation

@HypeMC
Copy link
Member

QA
Branch?7.1
Bug fix?no
New feature?no
Deprecations?no
Issues-
LicenseMIT

Inspired by#53448 (comment)

@nicolas-grekas
Copy link
Member

nicolas-grekas commentedJan 22, 2024
edited
Loading

I doubt this matters, and I also dunno if it's faster at all. PCRE is way heavier that a simple string check.
Also, that's not an improvement to the readability of the code base to me and it will make reviewing PRs that add new schemes harder.
I'm closing therefor. Thanks for proposing.

@HypeMCHypeMC deleted the optimize-storefactory branchJanuary 22, 2024 23:14
@HypeMC
Copy link
MemberAuthor

@nicolas-grekas When I ran the benchmark for#53448, it was marginally faster, but I agree that readability takes a hit. I just wanted someone to confirm that it's not worth it, thanks 😄

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@jderussejderusseAwaiting requested review from jderussejderusse is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

7.1

Development

Successfully merging this pull request may close these issues.

3 participants

@HypeMC@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp