Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Cache][Lock][Semaphore] Optimize factories#53598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedJan 22, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I doubt this matters, and I also dunno if it's faster at all. PCRE is way heavier that a simple string check. |
HypeMC commentedJan 22, 2024
@nicolas-grekas When I ran the benchmark for#53448, it was marginally faster, but I agree that readability takes a hit. I just wanted someone to confirm that it's not worth it, thanks 😄 |
Inspired by#53448 (comment)