Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Mailer][Webhook] Add MailerSend support#53583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedJan 19, 2024
Hey! To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done? Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review. Cheers! Carsonbot |
carsonbot commentedJan 19, 2024
Hey! Thanks for your PR. You are targeting branch "7.1" but it seems your PR description refers to branch "7.1 for features". Cheers! Carsonbot |
carsonbot commentedJan 19, 2024
It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you. Cheers! Carsonbot |
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Christian Flothmann <christian.flothmann@gmail.com>
xabbuh commentedJan 19, 2024
You will also have to add |
…nd/symfony into mailersend-webhook-remote-event
Uh oh!
There was an error while loading.Please reload this page.
| protectedfunctiondoParse(Request$request, #[\SensitiveParameter]string$secret): ?AbstractMailerEvent | ||
| { | ||
| if ($secret) { | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This empty line should be removed
| $content =$request->toArray(); | ||
| if ( | ||
| !isset($content['type'],$content['data']['email']['message']['id'],$content['data']['email']['recipient']['email']) | ||
| ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Should be all on one line
fabpot commentedFeb 3, 2024
As I cannot push upstream, I've finished the work here:#53740 |
Uh oh!
There was an error while loading.Please reload this page.
Support webhooks fromMailerSend
MailerSend developersdocumentation