Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[FrameworkBundle] grab a service from the container only if it exists#53572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:6.3fromxabbuh:issue-53551
Jan 22, 2024

Conversation

xabbuh
Copy link
Member

@xabbuhxabbuh commentedJan 18, 2024
edited
Loading

QA
Branch?6.3
Bug fix?yes
New feature?no
Deprecations?no
IssuesFix#53551
LicenseMIT

@xabbuh
Copy link
MemberAuthor

The root cause for the observed behaviour is that the list of pool names passed to the constructor ofCachePoolClearCommand command contains also the ids of cache pools that are later cleaned up by theRemoveUnusedDefinitionsPass. An alternative solution would be to collect available cache pool names at a later stage during compilation when the cleanup of unused service definitions has already happened.

@nicolas-grekas
Copy link
Member

Can't we check if the service exists before accessing it? Because this strategy is going to keep around pools that are not used, preventing them to be cleaned up by the compilation process.

@xabbuhxabbuh changed the title[Validator] keep a reference to all cache pools[Cache] keep a reference to all cache poolsJan 22, 2024
@xabbuhxabbuh changed the title[Cache] keep a reference to all cache pools[FrameworkBundle] grab a service from the container only if it existsJan 22, 2024
@xabbuh
Copy link
MemberAuthor

indeed, that's a better idea

@xabbuhxabbuh changed the base branch from5.4 to6.3January 22, 2024 10:26
@xabbuhxabbuh modified the milestones:5.4,6.3Jan 22, 2024
@carsonbotcarsonbot changed the title[FrameworkBundle] grab a service from the container only if it exists[Validator]  grab a service from the container only if it existsJan 22, 2024
@OskarStark
Copy link
Contributor

Why the Validator label?

@xabbuhxabbuh changed the title[Validator]  grab a service from the container only if it exists[FrameworkBundle] grab a service from the container only if it existsJan 22, 2024
@xabbuh
Copy link
MemberAuthor

probably because I made a typo in the initial title and didn't remove the label when fixing that so Carson re-adds it again

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM with one minor tweak

@nicolas-grekas
Copy link
Member

Thank you@xabbuh.

@nicolas-grekasnicolas-grekas merged commit8d8c8fe intosymfony:6.3Jan 22, 2024
@xabbuhxabbuh deleted the issue-53551 branchJanuary 22, 2024 21:11
This was referencedJan 30, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

@lyrixxlyrixxAwaiting requested review from lyrixx

@ycerutoycerutoAwaiting requested review from yceruto

@chalasrchalasrAwaiting requested review from chalasr

@dunglasdunglasAwaiting requested review from dunglas

Assignees
No one assigned
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.

4 participants
@xabbuh@nicolas-grekas@OskarStark@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp