Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Serializer] RewriteAbstractObjectNormalizer::createChildContext() to use the providedcache_key from original context when creating child contexts#53530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:5.4fromamne:5.4
Jan 29, 2024

Conversation

amne
Copy link
Contributor

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
IssuesN/A
LicenseMIT

If the normalization starts with an initial 'cache_key' it is currently discarded when creating child contexts. This change fixes that.
The main reason behind it is that if the client code sends a unique identifier (ApiPlatform injects the IRI) and we have a use case
that iterates a big resultset we end up with a big private cache that quickly runs out of allowed memory. The solution should be to
send a 'cache_key' which skips the entire cache key calculation that hashes the context.

@mtarld
Copy link
Contributor

Follow-up of#53523

@amneamne changed the title[Serializer] RewriteAbstractObjectNormalizer::createChildContext() to use the provided cache_key from original context when creating child contexts[Serializer] RewriteAbstractObjectNormalizer::createChildContext() to use the providedcache_key from original context when creating child contextsJan 13, 2024
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM with minor CS comments

… to use the provided `cache_key` from original context when creating child contexts
@nicolas-grekas
Copy link
Member

Thank you@amne.

@nicolas-grekasnicolas-grekas merged commitaf9fa66 intosymfony:5.4Jan 29, 2024
nicolas-grekas added a commit that referenced this pull requestJan 29, 2024
…false (xabbuh)This PR was merged into the 5.4 branch.Discussion----------[Serializer]  do not overwrite the cache key when it is false| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Issues        |Fix#53530 (comment)| License       | MITCommits-------fd00244 do not overwrite the cache key when it is false
This was referencedJan 30, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@mtarldmtarldmtarld approved these changes

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

4 participants
@amne@mtarld@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp